add cyclenet #171
Merged
add cyclenet #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'add-fredformer' --------- Co-authored-by: Yisong Fu <[email protected]>
|
Thanks very much for your significant contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CycleNet用了OneCycleLR，需要指定一些参数，我从load_dataset_desc读了一些信息，steps_per_epoch这个参数是估计的，跟实际有一点点出入但感觉应该不影响。
另外arch的forward里面需要传入batch index，实际上就是时间戳的index，我直接用时间特征恢复了。如果要跟原作者保持一致根本的做法还是在forward里面加上，但是得改simple_tsf_dataset和simple_tsf_runner，感觉改动有点多。
复现结果：
ETTm2 0.163, 0.246 VS 0.162, 0.241
ECL 0.136, 0.229 VS 0.163, 0.249
Traffic 0.458, 0.296 VS 0.498, 0.306
Wea 0.158, 0203 VS 0.160, 0.196
只跑了一个种子，大概也能对上，另外我感觉原作者有个地方写错了，先跟原作者保持一致，之后确认了再更新