Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the resolution (dpi) for better quality and change argument --url to prompt #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

afandiazmi
Copy link

@afandiazmi afandiazmi commented Jul 19, 2023

and

  • also Set JPEG quality to maximum (100%)
  • Remove the '--url' argument from the parser
  • Remove the 'args.url' assignment
  • Remove the 'id' assignment from the URL
  • Add prompt to ask for Prezi Links
  • Add prompt to ask for PDF name

@afandiazmi afandiazmi changed the title Increase the resolution (dpi) for better quality Increase the resolution (dpi) for better quality and change argument --url to prompt Jul 19, 2023
@Gertje823
Copy link
Owner

Hi,
Thanks fot the PR.
When comparing the output between your script and mine I see no difference in quality in the pdf.
The file size is identical and the quality does not seem better.
Did the quality of the pdf files improve in your tests?

Also the --url arguments are used to run the script without user input. Maybe we could implement both.
If you for example don't set the --url argument it will prompt you for a url and else use the url from the --url argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants