Merge "Make blame annotation as link"

GerritCodeReview · Feb 14, 2020 · 8bb537d · 8bb537d
2 parents 25edb49 + 2785ddf
commit 8bb537d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
@@ -577,11 +577,9 @@
     const blameNode = this._createElement('span',
         isStartOfRange ? 'startOfRange' : '');
 
-    const shaNode = this._createElement('span', 'blameDate');
+    const shaNode = this._createElement('a', 'blameDate');
     shaNode.innerText = `${date}`;
-    shaNode.onclick = function() {
-      location.href = '/q/' + commit.id;
-    };
+    shaNode.setAttribute('href', `/q/${commit.id}`);
     blameNode.appendChild(shaNode);
 
     const shortName = commit.author.split(' ')[0];

diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
@@ -281,7 +281,7 @@
       td.blame .blameDate {
         font-family: var(--monospace-font-family);
         color: var(--link-color);
-        cursor: pointer;
+        text-decoration: none;
       }
       .full-width td.blame {
         overflow: hidden;