Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative instead of absolute paths #12

Closed
jakobrosenberg opened this issue Mar 31, 2022 · 7 comments
Closed

Relative instead of absolute paths #12

jakobrosenberg opened this issue Mar 31, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@jakobrosenberg
Copy link

Is it possible to change this to a relative path? I imagine it could cause confusion or even breakage on other machines.

image

@Gerrit0 Gerrit0 added needs-repro bug Something isn't working labels Mar 31, 2022
@Gerrit0
Copy link
Owner

Gerrit0 commented Mar 31, 2022

Definitely needs investigation; this looks like a bug to me.

@Gerrit0 Gerrit0 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2022
@jimblanc
Copy link

jimblanc commented Feb 16, 2024

Running into the same issue and noticed this was closed as "not planned". @jakobrosenberg were you ever able to resolve? @Gerrit0 any idea of the root-cause?

@Gerrit0
Copy link
Owner

Gerrit0 commented Feb 16, 2024

GitHub shows not planned for any of the non-"done" reasons. In this case, closed because no minimal reproduction was provided so it is unworkable.

@jimblanc
Copy link

That's fair, I'll work on seeing if I can boil down a reproduction app.

@blutorange
Copy link

blutorange commented Sep 23, 2024

@Gerrit0 I made a sample project for testing how to document the JavaScript code of a different project. I'll probably change a lot of the setup, but also came across this issue. I made a branch with the state where this issue occurs, try the following to reproduce it:

git clone https://github.com/blutorange/primefaces-js-refactor-test.git
cd primefaces-js-refactor-test/
git checkout typedoc-plugin-missing-exports-issue-12
npm install
cd packages/core/
npx tsc
npm run typedoc
open docs/index.html

Then open docs/index.html, I get the following with absolute links:

image

@Gerrit0
Copy link
Owner

Gerrit0 commented Sep 24, 2024

Ah, that makes a ton of sense... ick. It's probably going to require some terrible hack to fix this.

@Gerrit0 Gerrit0 reopened this Sep 24, 2024
blutorange pushed a commit to blutorange/primefaces-js-refactor-test that referenced this issue Nov 13, 2024
@blutorange
Copy link

blutorange commented Nov 13, 2024

@Gerrit0 For reference, this can also cause an error when generating the documentation, in conjunction with yarn's PNP mode:

[error] Could not write /home/user/tmp/repro/primefaces-js-refactor-test/docs/modules/internal._home_user_tmp_repro_primefaces_js_refactor_test__yarn___virtual____fullcalendar_interaction_virtual_507a71b689_4__yarn_berry_cache__fullcalendar_interaction_npm_6_1_15_20b6da9676_10c0_zip_node_modules__fullcalendar_interaction_index.html

The OS complains because the filename it tries to use it too long (touch: cannot touch '...': File name too long). Simple reproduction:

git clone https://github.com/blutorange/primefaces-js-refactor-test.git
cd primefaces-js-refactor-test/
git checkout demo-typedoc-issue-long-file-names
yarn install
yarn typedoc src/index.ts --out docs --plugin typedoc-plugin-missing-exports

This happens as soon as there are multiple imports / external modules. When you comment out one of the imports in index.ts, it only generates names like docs/classes/_internal_.Component.html

Though perhaps this would need to be addressed by the typedoc core, that it finds a way to avoid long file names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants