Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully remove Poetry #63

Merged
merged 6 commits into from
Dec 17, 2023
Merged

Fully remove Poetry #63

merged 6 commits into from
Dec 17, 2023

Conversation

brylie
Copy link
Member

@brylie brylie commented Dec 17, 2023

Removing poetry due to:

  1. complexities of having an additional dependency manager installation (aside from pip)
  2. observing some somewhat negative interactions with Poetry community in GitHub issues related to using Poetry for an application, instead of library, dependency manager
    • since this project is an application, which doesn't seem to be Poetry's primary use case, we'll avoid the issue entirely

Time

  • 2023-12-17: 1

Copy link

codeclimate bot commented Dec 17, 2023

Code Climate has analyzed commit edec8cd and detected 21 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1
Security 2
Style 7
Bug Risk 5
Complexity 6

Note: there are 3 critical issues.

View more on Code Climate.

@brylie brylie merged commit 8ccf3bd into main Dec 17, 2023
@brylie brylie deleted the fix-pyproject.toml branch December 17, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant