Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client certificate support and example #1

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

eyazrgeotab
Copy link
Contributor

Support for client side certificates.

@aaront
Copy link
Contributor

aaront commented Nov 10, 2021

Hey @eyazrgeotab, I think the example file is unneeded for this.

Also, can you implement custom certs for the aiohttp async API (in py3/api_async.py)? I try to keep it a feature-parity interface with the syncronous API. Support for certificates can be added like: https://docs.aiohttp.org/en/stable/client_advanced.html#ssl-control-for-tcp-sockets

Thanks!

@aaront aaront self-assigned this Nov 10, 2021
@aaront aaront added this to the 0.8.7 milestone Nov 10, 2021
@eyazrgeotab
Copy link
Contributor Author

@aaront I removed the example and added certificate support to the async API as well.

@aaront aaront merged commit 42e68d3 into Geotab:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants