Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new observation form for custom observations #70

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

Bo-Duke
Copy link
Member

@Bo-Duke Bo-Duke commented Apr 24, 2024

No description provided.

@Bo-Duke Bo-Duke force-pushed the new_observation_types branch 4 times, most recently from bc0db61 to 72d19ec Compare April 29, 2024 17:00
@Bo-Duke Bo-Duke marked this pull request as ready for review April 29, 2024 17:02
@Bo-Duke Bo-Duke force-pushed the new_observation_types branch from 72d19ec to 40f9a78 Compare April 29, 2024 17:04
src/api/customObservations.ts Outdated Show resolved Hide resolved
src/api/customObservations.ts Outdated Show resolved Hide resolved
Comment on lines +86 to +87
const schema = await fetchObservation(type);
const detailsList = await fetchObservationDetails(type);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can use a Promise.all to parallelize queries?

src/api/customObservations.ts Outdated Show resolved Hide resolved
src/api/stations.ts Outdated Show resolved Hide resolved
@@ -34,10 +35,12 @@
"next": "^13.5.4",
"next-intl": "2.15.0-beta.5",
"next-themes": "^0.2.1",
"node-fetch": "^3.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful?

src/components/map/geometry-tooltip.tsx Outdated Show resolved Hide resolved
src/components/observation-cta.tsx Outdated Show resolved Hide resolved
src/components/observation-cta.tsx Outdated Show resolved Hide resolved
@Bo-Duke Bo-Duke requested a review from dtrucs February 6, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants