-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new observation form for custom observations #70
Open
Bo-Duke
wants to merge
30
commits into
main
Choose a base branch
from
new_observation_types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo-Duke
force-pushed
the
new_observation_types
branch
4 times, most recently
from
April 29, 2024 17:00
bc0db61
to
72d19ec
Compare
Bo-Duke
force-pushed
the
new_observation_types
branch
from
April 29, 2024 17:04
72d19ec
to
40f9a78
Compare
…l_pages Feat: Add button to redirect user to external page if link on content
feat: add external uri button on Station
dtrucs
reviewed
May 13, 2024
Comment on lines
+86
to
+87
const schema = await fetchObservation(type); | ||
const detailsList = await fetchObservationDetails(type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can use a Promise.all
to parallelize queries?
@@ -34,10 +35,12 @@ | |||
"next": "^13.5.4", | |||
"next-intl": "2.15.0-beta.5", | |||
"next-themes": "^0.2.1", | |||
"node-fetch": "^3.3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful?
dtrucs
requested changes
Nov 4, 2024
dtrucs
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.