Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested changes #2

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Suggested changes #2

merged 4 commits into from
Mar 24, 2022

Conversation

yuvipanda
Copy link

  • Move CILogonOAuthenticator default config values to values.yaml directly,
    these aren't used as long as CILogonAuthenticator is not enabled.
  • Add warning about picking USERNAME_KEY
  • Fix some typos

@yuvipanda yuvipanda mentioned this pull request Mar 23, 2022
Merged
GeorgianaElena
GeorgianaElena approved these changes Mar 24, 2022
View reviewed changes
Copy link
Owner

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these @yuvipanda

@GeorgianaElena GeorgianaElena merged commit 012a084 into GeorgianaElena:cilogon-admin Mar 24, 2022
GeorgianaElena pushed a commit that referenced this pull request May 2, 2022
@yuvipanda
Merge pull request #2 from sgibson91/update-ci
0691462 
Add m2lines cluster to deploy-hubs CI/CD workflow
GeorgianaElena pushed a commit that referenced this pull request Jun 13, 2024
@wildintellect
Merge pull request #2 from NASA-IMPACT/eis-fire
69d6494 
Bring Master up to date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @GeorgianaElena