Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support namespaced records for inet_contains #26

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Support namespaced records for inet_contains #26

merged 2 commits into from
Jul 1, 2019

Conversation

znakaska
Copy link
Contributor

I'm not entirely sure why inet_contains generated an Arel::Nodes::Contains node, but this creates an Arel::Nodes::Inet::Contains node to bypass the const lookup from table name.

Closes #25

@GeorgeKaraszi
Copy link
Owner

Thanks for the contribution and the changes look good 👍

@GeorgeKaraszi GeorgeKaraszi merged commit 8513fc4 into GeorgeKaraszi:master Jul 1, 2019
@znakaska znakaska deleted the namespaced-inet branch July 1, 2019 16:18
@davidgoldelocks davidgoldelocks mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespaced record class breaks inet_contains
2 participants
@znakaska @GeorgeKaraszi