feat(status): cards & peertube viewer #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally, inputstream + mediastream should be used for peertube but i've fallen into this bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/4062 using file with uri works but doesn't seem to exit correctly (sound still plays even after destroying) |
|
The stopping issue seems to have been fixed by unpreparing the stream 🤷 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cards ✨
link:
video:
clicking on a card will show a dialog since it's an out-of-instance request and users should confirm for privacy reasons:
PeerTube 🐙
PeerTube videos should now play on the built-in media viewer
ℹ️ qualities higher than 720p become laggy on my machine (gstreamer backend, I haven't tested on ffmpeg) so I set some limits (720, 480, 360 are preferred unless they are not available)
Similarly, PeerTube videos require out-of-instance requests and a similar dialog shows up:
fix: #244
edit:
there's an option in settings to disable cards