Refactoring polytopes #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from refactoring
and introducing std::make_pair
and introducing std::make_pair
and introducing std::make_pair
vissarion
reviewed
Jun 18, 2020
vissarion
reviewed
Jul 24, 2020
Code refactoring
…aridas/volume_approximation into Refactoring_polytopes
fix bugs on zonotope destructor
fix warnings in R tests
improve c++ tests
improve c++ tests
TolisChal
approved these changes
Sep 28, 2020
vissarion
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Thanks for this refactoring @elias-tsigaridas ! I am ok with merging and I have a few comments regarding code cleaning.
vissarion
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Eliminating "init" and refactoring of the constructors and introducing std::make_pair * Add implementation for the Big3 * Eliminate calls to Hpolytope.init * Eliminate free_them_all function call * fix R tests and improve c++ polytope generators * fix errors in R interface and cross polytope generator * Polishing according to the review in the PR. * fix bugs on zonotope destructor * remove Chebychev ball computation from the constructor Co-authored-by: TSIGARIDAS Elias <[email protected]> Co-authored-by: Tolis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved CMakeLists.txt in the root directory.
Eliminated the use of init in HPolytope and VPolytope.
Add constructors and destructor in VPolytope