CRHMC with Cooling Non-SphericalGaussians #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TolisChal
reviewed
Aug 18, 2024
| typedef typename NonSphericalGaussianFunctor::parameters<NT, Point> func_params; | ||
|
|
||
| typedef crhmc_input<MT, Point, Func, Grad, ZeroFunctor<Point>> Input; | ||
| //typedef crhmc_input<MT, Point, Func, Grad, Hess> Input; |
TolisChal
reviewed
Aug 18, 2024
|
|
||
| Input input = convert2crhmc_input<Input, Polytope, Func, Grad, ZeroFunctor<Point>>(P, f, g, zerof); | ||
|
|
||
| //Input input = convert2crhmc_input<Input, Polytope, Func, Grad, Hess>(P, f, g, h); |
TolisChal
reviewed
Aug 18, 2024
TolisChal
reviewed
Aug 18, 2024
| typedef typename NonSphericalGaussianFunctor::parameters<NT, Point> func_params; | ||
|
|
||
| typedef crhmc_input<MT, Point, Func, Grad, ZeroFunctor<Point>> Input; | ||
| //typedef crhmc_input<MT, Point, Func, Grad, Hess> Input; |
TolisChal
reviewed
Aug 18, 2024
| func_params initial_f_params = func_params(Point(dimension), a_vals[0], -1, inv_covariance_matrix); | ||
| Func initial_f(initial_f_params); | ||
| Grad initial_g(initial_f_params); | ||
| Hess initial_h(initial_f_params); |
There was a problem hiding this comment.
Since we use the zero functor for the hessian, do we need initial_h?
TolisChal
reviewed
Aug 18, 2024
TolisChal
reviewed
Aug 18, 2024
|
|
||
| Func f(f_params); | ||
| Grad g(f_params); | ||
| Hess h(f_params); |
TolisChal
reviewed
Aug 18, 2024
|
|
||
| Input input = convert2crhmc_input<Input, Polytope, Func, Grad, ZeroFunctor<Point>>(Pin_copy, f, g, zerof); | ||
|
|
||
| //Input input = convert2crhmc_input<Input, Polytope, Func, Grad, Hess>(P, f, g, h); |
TolisChal
reviewed
Aug 18, 2024
|
|
||
| //restore the new eta and start point, by looking at the walk after its operations | ||
| initial_eta = walk.get_current_eta(); | ||
| //start_point = walk.getPoint(); |
TolisChal
reviewed
Aug 18, 2024
| typedef typename NonSphericalGaussianFunctor::parameters<NT, Point> func_params; | ||
|
|
||
| typedef crhmc_input<MT, Point, Func, Grad, ZeroFunctor<Point>> Input; | ||
| //typedef crhmc_input<MT, Point, Func, Grad, Hess> Input; |
There was a problem hiding this comment.
I'd remove everything related to the Hessian, we should use the zero functor only.
TolisChal
reviewed
Aug 18, 2024
|
|
||
| //create the crhmc problem | ||
| Input input = convert2crhmc_input<Input, Polytope, Func, Grad, ZeroFunctor<Point>>(newPin, f, g, zerof); | ||
| //Input input = convert2crhmc_input<Input, Polytope, Func, Grad, Hess>(P, f, g, h); |
vgnecula
force-pushed
the
crhmc_cooling_nonspherical_gaussians
branch
from
7fc7895 to
3c3e904
Compare
TolisChal
approved these changes
Aug 21, 2024
|
Thanks @vgnecula! That's a crucial step towards a new implementation for volume estimation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.