Improve max volume ellipsoid computation #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfisikop
approved these changes
Jun 20, 2024
| } | ||
|
|
||
There was a problem hiding this comment.
please remove this trailing whitespace
| @@ -67,6 +78,12 @@ std::tuple<MT, VT, NT> max_inscribed_ellipsoid_rounding(Polytope &P, | |||
| P.normalize(); | |||
| x0 = VT::Zero(d); | |||
|
|
|||
| // check the roundness of the polytope | |||
| if(((std::abs(R / r) <= 6.0 && iter_res.second) || iter >= 5) || | |||
There was a problem hiding this comment.
instead of having a new bool variable aggressive_mode, we can have max_iterations as a parameter with default value 5 and if the user gives 1 then it is equivalent to aggressive_mode=true.
The above check becomes ((std::abs(R / r) <= 6.0 && iter_res.second) || iter >= max_iterations).
One variable less and more flexibility (max_iterations can take various values).
Should we also have another parameter max_ratio or max_sandwitch_ratio with default value 6?
There was a problem hiding this comment.
Thanks, I implemented both suggestions
| @@ -22,7 +22,8 @@ template | |||
| typename Point | |||
| > | |||
| std::tuple<MT, VT, NT> max_inscribed_ellipsoid_rounding(Polytope &P, | |||
| Point const& InnerPoint) | |||
| Point const& InnerPoint, | |||
| const bool aggressive_mode = false) | |||
| { | |||
| std::pair<std::pair<MT, VT>, bool> iter_res; | |||
There was a problem hiding this comment.
We can add a todo here to change this to std::tuple.
There was a problem hiding this comment.
Thanks, I added a comment in max_inscribed_ellipsoid.hpp
| @@ -44,18 +45,28 @@ std::tuple<MT, VT, NT> max_inscribed_ellipsoid_rounding(Polytope &P, | |||
| E = (E + E.transpose()) / 2.0; | |||
| E = E + MT::Identity(d, d)*std::pow(10, -8.0); //normalize E | |||
|
|
|||
| Eigen::LLT<MT> lltOfA(E); // compute the Cholesky decomposition of E | |||
| Eigen::LLT<MT> lltOfA(E.inverse()); // compute the Cholesky decomposition of E^{-1} | |||
There was a problem hiding this comment.
Is E psd? If so why not invert it more efficiently e.g. E.llt().solve(I)?
| // computing eigenvalues of E | ||
| Spectra::DenseSymMatProd<NT> op(E); | ||
| Spectra::SymEigsSolver<NT, Spectra::SELECT_EIGENVALUE::BOTH_ENDS, | ||
| Spectra::DenseSymMatProd<NT>> eigs(&op, 2, std::min(std::max(10, int(d)/5), int(d))); |
There was a problem hiding this comment.
could we add a comment on the numeric values here and how we select them?
There was a problem hiding this comment.
The values is chosen empirically. I added a comment.
TolisChal
added a commit
that referenced
this pull request
Jul 7, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments --------- Authored-by: Apostolos Chalkis (TolisChal) <[email protected]>
TolisChal
added a commit
that referenced
this pull request
Jul 7, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments
TolisChal
added a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 7, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments
TolisChal
added a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 7, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments
TolisChal
added a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments
TolisChal
added a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments
TolisChal
added a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments
TolisChal
added a commit
that referenced
this pull request
Jul 17, 2024
* improve the implementation of maximum ellipsoid computation * minor fix in rounding unit-test * fix file copyrights * apply termination criterion after transformation in max ellipsoid rounding * resolve PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.