Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Documentation #261

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

Soumya624
Copy link
Contributor

Added few lines before ctest -jK command. And attached few steps to set up the upstream remote

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #261 (4ae56ea) into develop (423bbcf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #261   +/-   ##
========================================
  Coverage    53.85%   53.85%           
========================================
  Files          105      105           
  Lines         6167     6167           
  Branches      2874     2874           
========================================
  Hits          3321     3321           
  Misses         972      972           
  Partials      1874     1874           

@vissarion
Copy link
Member

@Soumya624 sorry for the late reply and thanks for your PR!

I was testing again volesti with MKL and found there are some issues with MKL in some versions/platforms. I am looking into it and will return with more details.

Regarding this PR now, I think that your addition is useful, but maybe a better place would be the documentation rather than the contributions guide since building volesti is also a user topic.

Would you like to add your additions in the documentation? Then we can add a link to the contributions guide.
You can write/propose/edit a section here. The documentation is build automatically and displayed here

@vissarion vissarion self-requested a review February 14, 2023 09:12
@Soumya624
Copy link
Contributor Author

Soumya624 commented Feb 19, 2023

@vissarion Sure. Will update in this PR

@vissarion vissarion changed the title Updating CONTRIBUTING.md Updating documentation Feb 20, 2023
@vissarion vissarion merged commit 9d495d6 into GeomScale:develop Feb 20, 2023
@Soumya624 Soumya624 changed the title Updating documentation Updating Documentation Jul 11, 2023
iakoviid pushed a commit to iakoviid/volesti that referenced this pull request Nov 1, 2023
* Enable github actions to build examples. Avoid passing a polytope as a const reference.

* Fix ambiguous call to fix function by renaming volesti's diagnostic function. (GeomScale#263)

* Updating documentation (GeomScale#261)

Adding WSL and MKL build instructions.

* disable an R sampling test for windows

* Fix the warning message in R Mac's cran test (GeomScale#285)

* copy and replace lp_rlp.h

* remove re-initialization of eta

* update ubuntu version from 18 to 20 in R cran tests

* minor improvements (explanatory comments)

---------

Co-authored-by: Apostolos Chalkis <[email protected]>

* delete commented out code

* No-U-Turn Sampler in HMC (GeomScale#216)

* initialize nuts sampler class

* implement the burnin of nuts sampler

* add tests and resolve bugs

* implement e0 estimation in burnin of nuts

* optimize leapfrog

* integrate nuts into the R interface

* document random walk in sample_points.cpp in R interface

* fix burnin for the non-truncated case

* resolve bugs in hmc and nuts pipelines

* improve the preprocess in burin step of nuts

* split large lines in sample_points.cpp

* Add NUTS C++ example and update CMake (GeomScale#29)

* resolve PR comments

* fix minor bug

* fix compiler bug

* fix error in building the C++ examples

* resolve warnings in sample_points

* fix lpsolve cran warning

* fix cran warning on mac

* improve lpsolve cmake for cran check

* fix R warning in mac test

* remove lpsolve header

* resolve PR comments

---------

Co-authored-by: Marios Papachristou <[email protected]>
Co-authored-by: Apostolos Chalkis <[email protected]>

---------

Co-authored-by: Vissarion Fisikopoulos <[email protected]>
Co-authored-by: Soumya Tarafder <[email protected]>
Co-authored-by: Apostolos Chalkis <[email protected]>
Co-authored-by: Marios Papachristou <[email protected]>
TolisChal pushed a commit that referenced this pull request Jul 7, 2024
Adding WSL and MKL build instructions.
TolisChal pushed a commit that referenced this pull request Jul 7, 2024
Adding WSL and MKL build instructions.
TolisChal pushed a commit to TolisChal/volume_approximation that referenced this pull request Jul 7, 2024
Adding WSL and MKL build instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants