Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: add "options" to the Georaster constructor #80

Merged
merged 5 commits into from
Aug 6, 2023

Conversation

ajgrowney
Copy link
Contributor

Allow applications to forward custom headers to URLs (e.g. Authentication) when parsing georaster

@DanielJDufour
Copy link
Member

Looks great! Thank you so much!

P.S. Just a heads up that I'll probably keep these additional options undocumented at this time. I'm committed to maintaining backwards compatibility for all the public documented georaster API (even across the next major upgrade). And it might be nice to change the options object in the future. It's not necessary now, but once georaster adds support for ascii grid and other raster formats, perhaps explicitly defining geotiff.js options vs. other options might be nice.

P.P.S. Awesome! I didn't know geotiff.js supported passing along headers until you submitted the PR!

@DanielJDufour DanielJDufour merged commit 01dff42 into GeoTIFF:master Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants