Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSH: use engine='python' as fallback in pandas to read ogs mesh #16

Merged
merged 5 commits into from
May 25, 2022

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented May 16, 2022

In some corner cases, reading a native OGS5 msh fails since the c-engine of pandas can't handle empty cols in some cases.
Using the python-engine as a fallback in this case can solve such problems.

Removed some old from io import open which were there for py2 compatibility.

@MuellerSeb MuellerSeb added the bug Something isn't working label May 16, 2022
@MuellerSeb MuellerSeb added this to the v1.2.2 milestone May 16, 2022
@MuellerSeb MuellerSeb self-assigned this May 16, 2022
@MuellerSeb
Copy link
Member Author

This should also be implemented for old-style meshes.

@MuellerSeb MuellerSeb merged commit 752e7bd into main May 25, 2022
@MuellerSeb MuellerSeb deleted the msh_read_fix branch May 25, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant