Refactor statistics calculations #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does an ND refactor of the statistics calculation routine. Here is a list of major changes: * The ```krige``` and ```krige3d``` methods in ```core``` have been merged in ```_krige```. * The ```find_statistics``` and ```find_statistics_3d``` methods in core have been merged into ```_find_statistics```.
|
Cool, thanks. You're much better with the nuances and details of Python than I am, so I appreciate the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does an ND refactor of the statistics calculation routine. Here is a list of major changes:
krigeandkrige3dmethods in thecoremodule have been merged in_krige.find_statisticsandfind_statistics_3dmethods incorehave been merged into_find_statistics._find_statisticshas been updated to deal with the potential for subsequent kriging points being too close together... Previously, the mean error could at times end up being basically zero (< 1e-10), which lead to problems in the statistics calculation. The should robustify the statistics calculation routine.This address steps 3 and 4 in #31.