Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory efficient grids during variogram computation #42

Merged
merged 5 commits into from
Feb 22, 2017

Conversation

basaks
Copy link
Collaborator

@basaks basaks commented Feb 18, 2017

For large problems this will conserve memory during variogram computation.

Copy link
Contributor

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code update looks good to me; thanks!

Not so sure about the .travis.yml changes though. The Miniconda-latest-Linux-x86_64.sh script points to,

Miniconda2-4.0.5-Linux-x86_64.sh	25.9M	2016-03-29 19:32:26	42dac45eee5e58f05f37399adda45e85

which is fairly old. To get the latest versions, I think we should use Miniconda3-latest-Linux-x86_64.sh (or Miniconda2-latest-Linux-x86_64.sh if we really want PY2).

+1 for using the conda virtual environement. We had this setup before it was removed in PR #17 as for some reason the system python was used even after activating the virtual environment, as far as I remember. Just mentioning it in case it matters for this PR (I don't think it does)...

@basaks
Copy link
Collaborator Author

basaks commented Feb 22, 2017

@rth thank you. Very useful and you attention to detail is amazing :)
Please merge when you are happy.

@basaks
Copy link
Collaborator Author

basaks commented Feb 22, 2017

To get the latest versions, I think we should use Miniconda3-latest-Linux-x86_64.sh (or Miniconda2-latest-Linux-x86_64.sh if we really want PY2).

I think we can create python3.x envs using mimiconda2.sh.
See how I created py2.7 env using it: https://travis-ci.org/bsmurphy/PyKrige/jobs/204137080#L370
and also py3.5 here: https://travis-ci.org/bsmurphy/PyKrige/jobs/204137078#L383.

I did not know anaconda2 could do python3.x envs before I created this PR :)

@rth
Copy link
Contributor

rth commented Feb 22, 2017

Thanks, everything looks good!

I did not know anaconda2 could do python3.x envs before I created this PR :)

Yeah, that is very practical for testing PY2/PY3 versions...

@rth rth merged commit 8dc9926 into GeoStat-Framework:master Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants