Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krige unification (Error) #95

Closed
wants to merge 8 commits into from
Closed

Krige unification (Error) #95

wants to merge 8 commits into from

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Jun 3, 2020 •
edited
Loading

Was reopened as #97

@MuellerSeb MuellerSeb added enhancement New feature or request Refactoring Code-Refactoring needed here Performance Performance related stuff. labels Jun 3, 2020
@MuellerSeb MuellerSeb added this to the 1.3 milestone Jun 3, 2020
@MuellerSeb MuellerSeb requested a review from LSchueler June 3, 2020 12:55
@MuellerSeb MuellerSeb self-assigned this Jun 3, 2020
This was linked to issues Jun 3, 2020
Proposal: unify kriging routines #79
Closed
Issues with Kriging values #89
Closed
@MuellerSeb MuellerSeb marked this pull request as draft June 3, 2020 12:56
@MuellerSeb MuellerSeb mentioned this pull request Jun 3, 2020
Closed
LSchueler
LSchueler requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! Great work!
I think readability would increase by writing one more method, see comment in code.
Apart from that, I didn't see any more problems.

I'm eagerly awaiting the examples ;-)

gstools/krige/base.py Show resolved Hide resolved
@MuellerSeb MuellerSeb marked this pull request as ready for review July 15, 2020 16:16
@MuellerSeb MuellerSeb closed this Jul 15, 2020
@MuellerSeb
Copy link
Member Author

The latest commits (after 6565d55) are not listed here... I'll close this PR and open another one to see if this helps.

@MuellerSeb MuellerSeb removed this from the 1.3 milestone Jan 12, 2021
@MuellerSeb MuellerSeb removed their assignment Jan 12, 2021
@MuellerSeb MuellerSeb removed Performance Performance related stuff. Refactoring Code-Refactoring needed here enhancement New feature or request labels Jan 12, 2021
@MuellerSeb MuellerSeb changed the title Krige unification Krige unification (Error) Jan 12, 2021
This was unlinked from issues Jan 12, 2021
Proposal: unify kriging routines #79
Closed
Issues with Kriging values #89
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuellerSeb @LSchueler