-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: update setuptools config and CI #241
Conversation
OpenMP support was never available in CI for macOS. There is also an open PR for clang/openmp support on macOS here: astropy/extension-helpers#42 We could wait for this PR to be merged and then we could install openmp with brew for macOS: - name: macos openmp install
uses: mstksg/get-package@v1
if: matrix.os == 'macos-latest'
with:
brew: libomp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice improvement in the setup! A small fix in the toml-file and you're ready to merge this 👍
When this is implemented, we can even drop the |
Changes:
setup.cfg
content topyproject.toml
(PEP 621)pyproject.toml
config with setuptools)src/
based package structure (better for testing, building and structure)setup.py