-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field: make Field.mesh compatible with meshio v5.1+ #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this bugfix. 👍
But why do you think we should continue supporting older meshio versions? If someone wants to update GSTools
, meshio
can also be updated. I fear that this could make it much more difficult to maintain or own code, with mutiple branching dependencies.
And I just checked, meshio
does not provide bugfixes for older major versions.
Guess you are right. So I will bump the minimum version of meshio to 5.1 and remove the upper restriction to not make it a blocker in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to the "... I will bump the minimum version of meshio to 5.1..."?
?! I did this before, but to support py36 as discussed, I needed to support meshio 4 since meshio 5+ only supports py37+. That is why I reverted this as we agreed on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay... I need a coffee, some fresh air and shouldn't work as much ;-)
Trying to nail it down. This looks strange in the log for
last working version looked like this:
It looks like numpy is now build from source whereas a wheels was taken last time. For py37 it takes a wheel:
Maybe we can pin the numpy version for testing to |
Closes #226