Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field: make Field.mesh compatible with meshio v5.1+ #227

Merged
merged 13 commits into from
Jan 15, 2022
Merged

Conversation

MuellerSeb
Copy link
Member

Closes #226

@MuellerSeb MuellerSeb added bug Something isn't working external problem labels Dec 15, 2021
@MuellerSeb MuellerSeb added this to the 1.3.5 milestone Dec 15, 2021
@MuellerSeb MuellerSeb requested a review from LSchueler December 15, 2021 13:36
@MuellerSeb MuellerSeb self-assigned this Dec 15, 2021
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this bugfix. 👍

But why do you think we should continue supporting older meshio versions? If someone wants to update GSTools, meshio can also be updated. I fear that this could make it much more difficult to maintain or own code, with mutiple branching dependencies.
And I just checked, meshio does not provide bugfixes for older major versions.

@MuellerSeb
Copy link
Member Author

Guess you are right. So I will bump the minimum version of meshio to 5.1 and remove the upper restriction to not make it a blocker in the future.

Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the "... I will bump the minimum version of meshio to 5.1..."?

setup.cfg Show resolved Hide resolved
@MuellerSeb
Copy link
Member Author

What happened to the "... I will bump the minimum version of meshio to 5.1..."?

?! I did this before, but to support py36 as discussed, I needed to support meshio 4 since meshio 5+ only supports py37+. That is why I reverted this as we agreed on.

Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay... I need a coffee, some fresh air and shouldn't work as much ;-)

@MuellerSeb
Copy link
Member Author

Trying to nail it down. This looks strange in the log for ubuntu i686:

2022-01-12T21:36:56.7636311Z Collecting numpy>=1.14.5
2022-01-12T21:36:56.7637269Z   Downloading numpy-1.22.0.zip (11.3 MB)
2022-01-12T21:36:56.7638159Z   Installing build dependencies: started
2022-01-12T21:36:56.7639410Z   Installing build dependencies: finished with status 'done'
2022-01-12T21:36:56.7640459Z   Getting requirements to build wheel: started
2022-01-12T21:36:56.7641701Z   Getting requirements to build wheel: finished with status 'done'
2022-01-12T21:36:56.7642735Z     Preparing wheel metadata: started
2022-01-12T21:36:56.7644306Z     Preparing wheel metadata: finished with status 'done'

last working version looked like this:

2021-12-15T13:54:46.9763629Z Collecting numpy<2,>=1.14.5
2021-12-15T13:54:46.9765160Z   Downloading numpy-1.21.4-cp38-cp38-manylinux_2_12_i686.manylinux2010_i686.whl (13.7 MB)

It looks like numpy is now build from source whereas a wheels was taken last time. For py37 it takes a wheel:

2022-01-12T21:29:50.6808690Z Collecting numpy>=1.14.5
2022-01-12T21:29:50.6809449Z   Downloading numpy-1.21.5-cp37-cp37m-manylinux_2_12_i686.manylinux2010_i686.whl (13.7 MB)

Maybe we can pin the numpy version for testing to <1.22.

@MuellerSeb MuellerSeb merged commit 60a601d into main Jan 15, 2022
@MuellerSeb MuellerSeb deleted the meshio5.1_fix branch January 15, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with MeshIO v5.1
2 participants