Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update init_guess in variogram fitting #145

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Update init_guess in variogram fitting #145

merged 4 commits into from
Mar 22, 2021

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Mar 21, 2021 •
edited
Loading

This PR adds the following changes:

  1. init_guess can now be given as a dictionary to CovModel.fit_variogram specifying initial values given per parameter name
    • additional "default" can be set to "default" or "current" to handle unspecified parameters
    • this "default" will be "default" by default
  2. initial guess for len_scale will be the mean of given bin centers to get correct order of magnitude (fixing Variogram fitting does not work for 'large' coordinates? #143 and What about bin width causes models not to fit/produce results? #144)
  3. initial guess for var and nugget will be the mean of the given variogram values to get correct order of magnitude

@MuellerSeb
CovModel: keep default opt args in line with the default bounds to ta…
c2d1d01 
…ckle a rare case of missing init guess values for fitting user defined models
@MuellerSeb
CovModel.fit_variogram: allow dict for init_guess; set init for len_s…
7180e87 
…cale to mean(bin_center) and for var/nugget to mean(variogram)
@MuellerSeb MuellerSeb added the enhancement New feature or request label Mar 21, 2021
@MuellerSeb MuellerSeb added this to the 1.3 milestone Mar 21, 2021
@MuellerSeb MuellerSeb requested a review from LSchueler March 21, 2021 13:49
@MuellerSeb MuellerSeb self-assigned this Mar 21, 2021
@MuellerSeb MuellerSeb mentioned this pull request Mar 21, 2021
Closed
@MuellerSeb MuellerSeb linked an issue Mar 21, 2021 that may be closed by this pull request
Variogram fitting does not work for 'large' coordinates? #143
Closed
LSchueler
LSchueler reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're ready to merge this one! 👍

@MuellerSeb
Copy link
Member Author

Ther have been some occasional fails of the CI for WIndows py35 with cibuildwheel. Let's keep an eye on that.

@MuellerSeb MuellerSeb merged commit 3f3a3ea into develop Mar 22, 2021
@MuellerSeb MuellerSeb deleted the better_init_fit_vario branch March 22, 2021 15:29
@MuellerSeb MuellerSeb mentioned this pull request Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler approved these changes

Assignees

@MuellerSeb MuellerSeb

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Variogram fitting does not work for 'large' coordinates?
2 participants
@MuellerSeb @LSchueler