Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CovModel.fit: check if weights are given as a string to prevent numpy comparison errors in the future #111

Merged
merged 1 commit into from
Nov 18, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gstools/covmodel/fit.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def _set_weights(model, weights, x_data, curve_fit_kwargs, is_dir_vario):
if weights is not None:
if callable(weights):
weights = 1.0 / weights(x_data)
elif weights == "inv":
elif isinstance(weights, str) and weights == "inv":
weights = 1.0 + x_data
elif is_dir_vario:
if weights.size * model.dim == x_data.size:
Expand Down