Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #10024] Wrong default style when creating layer #10025

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

etj
Copy link
Contributor

@etj etj commented Sep 16, 2022

References: #10024

Solves the problem of bad styles assigned to layer.

  • Main fix is by setting proper lock ids in celery tasks.
  • Added lot of debug logging, also useful for post-mortem investigations
  • Split some nested commands and improved robustness

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 16, 2022
@etj etj requested review from afabiani and giohappy September 16, 2022 09:11
@etj
Copy link
Contributor Author

etj commented Sep 16, 2022

@giohappy
Copy link
Contributor

@afabiani it would also be great if you could add some comments to the steps, to help understanding what we're doing in each of them. It's very hard to follow the logic of style, default styles, etc. management

@etj etj self-assigned this Sep 16, 2022
@giohappy
Copy link
Contributor

From my side all looks good @etj. I was able to reproduce the issue before the fix. Now it never happens.

@afabiani afabiani added this to the 4.0.2 milestone Sep 19, 2022
@afabiani afabiani changed the title #10024 Wrong default style when creating layer [Fixes #10024] Wrong default style when creating layer Sep 19, 2022
@afabiani afabiani merged commit 40fae5b into GeoNode:4.0.x Sep 19, 2022
@afabiani afabiani deleted the 10024_40x_style branch September 19, 2022 08:29
ridoo pushed a commit to Geonode-SEP-NFDI4Biodiversity/geonode that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.0.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants