Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests should use reverse instead of hard-coded URLs #427

Closed
ischneider opened this issue Oct 17, 2012 · 2 comments
Closed

integration tests should use reverse instead of hard-coded URLs #427

ischneider opened this issue Oct 17, 2012 · 2 comments

Comments

@ischneider
Copy link
Member

Not only does this make things easier to maintain in the long run, it prevents bogus results for bad tests (#426) that point to a url but don't check the status code as the reverse lookup will fail first.
@simod
Copy link
Member

simod commented Oct 18, 2012

Even if is marked as 5 days ago (probably the a vm issue), this 086de6f
d295878
is uses all reverse urls. Test passes after the Ariel's commits yesterday.

If is ok for you we can close.

@ischneider
Copy link
Member Author

Great, thanks @simod

marthamareal pushed a commit to marthamareal/geonode that referenced this issue Sep 24, 2021
@allyoucanmap
add search input to filter form (GeoNode#427)
e22bdbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simod @ischneider