Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API V1 delivers information on users that shouldn't be visible #11320

Closed
mattiagiupponi opened this issue Aug 3, 2023 · 0 comments
Closed

API V1 delivers information on users that shouldn't be visible #11320

mattiagiupponi opened this issue Aug 3, 2023 · 0 comments
Assignees
@mattiagiupponi
Labels
API v2
Milestone
4.2.0

Comments

@mattiagiupponi
Copy link
Contributor

mattiagiupponi commented Aug 3, 2023 •
edited
Loading

Expected Behavior

api/v1 works like api/v2

Actual Behavior

The same restrictions to the users returned by api/v2 users and groups endpoints must be ported to api/v1's owners and profiles.
In particular, the logic implemented inside get_available_users

Notes

must be enforced for the api/v1 endpoints, taking care of not breaking existing legacy functionality (like people and groups pages, message boxes, etc.).

Specifications

  • GeoNode version: master 4.1.x
  • Installation type (vanilla, geonode-project): any
  • Installation method (manual, docker): any
  • Platform:
  • Additional details:
@mattiagiupponi mattiagiupponi self-assigned this Aug 3, 2023
@mattiagiupponi mattiagiupponi added this to the 4.2.0 milestone Aug 3, 2023
mattiagiupponi added a commit that referenced this issue Aug 3, 2023
@mattiagiupponi
[Fixes #11320] API V1 delivers information on users that shouldn't be…
116caa0 
… visible
@mattiagiupponi mattiagiupponi mentioned this issue Aug 3, 2023
Merged
12 tasks
mattiagiupponi added a commit that referenced this issue Aug 7, 2023
@mattiagiupponi
[Fixes #11320] API V1 delivers information on users that shouldn't be…
54fe6f0 
… visible
github-actions bot pushed a commit that referenced this issue Aug 16, 2023
@mattiagiupponi @github-actions
[Fixes #11320] API V1 delivers information on users that shouldn't be… (
f2be725 
#11321)

* [Fixes #11320] API V1 delivers information on users that shouldn't be visible

* Fix black and flake8

* Fix black and flake8

* Fix black and flake8

* Fix black and flake8

* [Fixes #11320] API V1 delivers information on users that shouldn't be visible

---------

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit c84f55e)
giohappy pushed a commit that referenced this issue Aug 16, 2023
@github-actions @mattiagiupponi
[Fixes #11320] API V1 delivers information on users that shouldn't be… (
21bbee8 
#11321) (#11384)

* [Fixes #11320] API V1 delivers information on users that shouldn't be visible

* Fix black and flake8

* Fix black and flake8

* Fix black and flake8

* Fix black and flake8

* [Fixes #11320] API V1 delivers information on users that shouldn't be visible

---------

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit c84f55e)

Co-authored-by: mattiagiupponi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattiagiupponi mattiagiupponi

Labels
API v2
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
1 participant
@mattiagiupponi