Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map180 #54

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Map180 #54

merged 2 commits into from
Feb 8, 2019

Conversation

danieldooley
Copy link
Contributor

@danieldooley danieldooley commented Feb 7, 2019

Proposed Changes

Changes proposed in this pull request:

  • Move map180 into kit

This includes changes made in: GeoNet/map180#4 (@junghao I've added an env.list to include the default configuration you removed)

Have also made some changes (adding an init() to nzmap_test.go) to make this package work with the TravisCI build.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@danieldooley danieldooley requested review from bpeng and junghao February 7, 2019 03:14
@danieldooley danieldooley force-pushed the map180 branch 2 times, most recently from 5554bd3 to c7006fa Compare February 7, 2019 03:56
junghao
junghao previously approved these changes Feb 7, 2019
Copy link
Contributor

@junghao junghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@danieldooley danieldooley merged commit adb6c04 into GeoNet:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants