Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helper function to check whether -check flag used #181

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

CallumNZ
Copy link
Contributor

@CallumNZ CallumNZ commented Nov 13, 2024

Changes proposed in this pull request:

  • Add helper to parse -check flag. Not tested, just an idea.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

bpeng
bpeng previously approved these changes Nov 14, 2024
Copy link
Contributor

@bpeng bpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK, doesn't simplify code but by breaking the code in the calling functionhealthCheck would make the code logic clearer.

@sue-h-gns sue-h-gns merged commit f2c17e5 into main Nov 17, 2024
7 checks passed
@sue-h-gns sue-h-gns deleted the checkIfCheck branch November 17, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants