Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reusable workflow #251

Merged
merged 1 commit into from
Jul 4, 2024
Merged

chore: reusable workflow #251

merged 1 commit into from
Jul 4, 2024

Conversation

junghao
Copy link
Contributor

@junghao junghao commented Jun 26, 2024

As requested in https://github.com/GeoNet/tickets/issues/15422

Extras:

  • some code formatting changes due to goimports
  • some init() reads env vars, and unfortunately there's no env vars pre-loaded during testing on GithubActions, so change those init() to a normal function, and made a call to it while starting (eg. in main() or setup(t))

@junghao junghao force-pushed the go-reusable branch 14 times, most recently from 99219bf to 5b75bdb Compare June 26, 2024 22:28
Copy link
Contributor

@CallumNZ CallumNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
I probably would've split out into multiple commits, because this is not just a chore, it's a build, refactor, and chore.

@sue-h-gns sue-h-gns merged commit 0a152f2 into main Jul 4, 2024
11 checks passed
@junghao junghao deleted the go-reusable branch July 4, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants