Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove FDSN-NRT related code #248

Merged
merged 1 commit into from
Jun 14, 2024
Merged

chore: remove FDSN-NRT related code #248

merged 1 commit into from
Jun 14, 2024

Conversation

junghao
Copy link
Contributor

@junghao junghao commented May 2, 2024

As title. NRT service has been in a separated repo for years so removing them here reduces maintenance efforts (e.g. dependency updates, security fixes).

Note: this PR does not update existing dependencies, only removing unused dependencies required by NRT codes.

@junghao junghao requested a review from wilsonjord May 2, 2024 02:14
wilsonjord
wilsonjord previously approved these changes May 2, 2024
Copy link

@wilsonjord wilsonjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tidy up

@junghao junghao closed this May 7, 2024
@junghao junghao deleted the remove-nrt branch May 7, 2024 03:47
@junghao junghao restored the remove-nrt branch May 7, 2024 03:47
@junghao junghao reopened this May 7, 2024
@junghao
Copy link
Contributor Author

junghao commented Jun 14, 2024

@wilsonjord I've rebased the commits and deployed in dev. Could you please have another review? Thanks

@sue-h-gns sue-h-gns merged commit fc26cb3 into main Jun 14, 2024
9 checks passed
@sue-h-gns sue-h-gns deleted the remove-nrt branch June 14, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants