Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcgis dependency updates #316

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Arcgis dependency updates #316

merged 2 commits into from
Sep 11, 2024

Conversation

CallumNZ
Copy link
Contributor

@CallumNZ CallumNZ commented Sep 5, 2024

Updated numpy, pandas, and geopandas.
Ran integration test with downstream application, works fine.

@Mossman1215
Copy link
Contributor

minor quibble regarding the nfc: prefix
this is a change so should be marked with a fix: prefix
nfc would be for non technical change like documentation or user access changes

@CallumNZ
Copy link
Contributor Author

CallumNZ commented Sep 5, 2024

oh! ok, I don't understand nfc 😅

@Mossman1215
Copy link
Contributor

oh! ok, I don't understand nfc 😅

no worries

Commit Body FAILED Commit body is empty

needs a body in the commit @CallumNZ

Poetry to v1.8.3 and Poetry-Plugin-Bundle to v1.4.1
numpy to v1.26.4, pandas to v2.1.4, geopandas to v1.0.1
Copy link
Contributor

@Mossman1215 Mossman1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets give it a go

@Mossman1215 Mossman1215 merged commit a645e50 into main Sep 11, 2024
25 checks passed
@Mossman1215 Mossman1215 deleted the arcgisUpdate branch September 11, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants