Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace custom sync script with skopeo #307

Merged
merged 1 commit into from
Aug 30, 2024
Merged

feat: replace custom sync script with skopeo #307

merged 1 commit into from
Aug 30, 2024

Conversation

Mossman1215
Copy link
Contributor

@Mossman1215 Mossman1215 commented Aug 26, 2024

custom sync script was failing to work and was generating a lot of toil

summary of the changes is captured in the docs change copied below

Sync an image

Images are synced by specifying source repositories in sync-ghcr.yml for github and sync-ecr.yml for ecs/ecr

check skopeo documentation for more details https://github.com/containers/skopeo/blob/main/docs/skopeo-sync.1.md

quay.io:
  tls-verify: true
  images:
    fedora/fedora-coreos:
      - stable

on pull requests skopeo sync runs with --dry-run

full sync runs when merged to main

@Mossman1215 Mossman1215 force-pushed the skopeo_sync branch 9 times, most recently from 99343d8 to dff3792 Compare August 26, 2024 01:33
@Mossman1215 Mossman1215 marked this pull request as ready for review August 26, 2024 01:54
custom sync script was failing to work and was generating a lot of toil
stop checking signatures until there is a better way to handle it
@Mossman1215 Mossman1215 requested review from ardrigh and a team August 26, 2024 02:41
Copy link
Contributor

@ardrigh ardrigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(YOLO Fridays. jk.) This looks good and we need to give this a run.

@ardrigh
Copy link
Contributor

ardrigh commented Aug 30, 2024

Using override to bypass not implemented check presubmit-signed-images-are-signed

@ardrigh ardrigh merged commit 23aa78f into main Aug 30, 2024
25 checks passed
@ardrigh ardrigh deleted the skopeo_sync branch August 30, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants