Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade GeoNet/alpine-gdal to Alpine 3.15 #130

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

junghao
Copy link
Contributor

@junghao junghao commented Oct 19, 2023

I assume currently the only project using this container is Shakinglayer, which's code only works with Gdal 3.4.

And, the Shakinglayer's base build image is Go1.16, which gives Gdal 3.4, and the existing GeoNet/alpine-gdal uses Alpine 3.18, give Gdal 3.6. This causes the runtime error.

Unfortunately we need to downgrade to Alpine 3.15 to get Gdal 3.4 so builder and runner can be in sync.
Also the code only works when it's Gdal 3.4.

Built instances deployed in dev environment works well.

@junghao junghao changed the title Downgrade Gdal version to 3.4.3. Downgrade GeoNet/alpine-gdal to Alpine 3.15 Oct 19, 2023
@junghao junghao changed the title Downgrade GeoNet/alpine-gdal to Alpine 3.15 fix: Downgrade GeoNet/alpine-gdal to Alpine 3.15 Oct 19, 2023
@junghao junghao force-pushed the gdal-version branch 4 times, most recently from 9a1c4a1 to 17f4fac Compare October 19, 2023 05:06
@junghao junghao requested a review from Mossman1215 October 19, 2023 05:15
currently the downstream application shakemap-data only works for this version
packages:
- alpine-baselayout-data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it's safe to remove the base layout directory structure package??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got build failed. Seems there's no such package in 3.15.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay that's fine

Copy link
Contributor

@Mossman1215 Mossman1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this,
let me know how the downstream shaking layer build goes

@Mossman1215 Mossman1215 merged commit 3691f04 into main Oct 19, 2023
16 checks passed
@Mossman1215 Mossman1215 deleted the gdal-version branch October 19, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants