feat: add parcel list modal #398
Conversation
| const foreclosureQuery = gql` | ||
| query Foreclosure($skip: Int) { | ||
| geoWebParcels( | ||
| first: 1000 |
There was a problem hiding this comment.
Do we need to get 1000 parcels here? Or can we limit it to MAX_LIST_SIZE?
There was a problem hiding this comment.
Here and in NeedsTransfer querying for only 25 parcels wouldn't result in 25 parcels foreclosed or that needs transfer because we don't have a way to query the subgraph directly for that, but e.g. need to call isPayerBidActive on each to tell if a parcel is foreclosed.
So we just get a pool of parcels to check and loop over them, performance should be alright even when there are 1000 parcels because it is done asynchronously.
A way to reduce the number of calls to the Ethereum node is to use ethers JsonRpcBatchProvider, in this comment the author was wondering if 1 million calls is too much so 1000 shouldn't be a problem.
There was a problem hiding this comment.
Great find on the JsonRpcBatchProvider. We should try to limit RPC calls as much as possible. Looks like this is working well with Infura.
I also see Ceramic multiqueries working well and also the Ceramic caching.
This does now result in many IPFS lookups via our delegate node. This should be fine, as they are only calls for content routing and do not return or fetch actual content. However, there are many 404s to /block/stat. I will look into how to remove these calls, as they are unnecessary. findprovs is what is needed.
Description
Add a modal to list 25 parcels sorted by either highest value, recent claims, random, needs transfer, foreclosure or outstanding bid.
Issue
fixes #392
Checklist:
developbranchdevelopbranchAlert Reviewers
@codynhat @gravenp