-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo and link #927
fix typo and link #927
Conversation
@@ -99,7 +99,7 @@ page at http://checkstyle.sourceforge.net/config.html --> | |||
<module name="WhitespaceAround" /> | |||
|
|||
<!-- Modifier Checks --> | |||
<!-- See http://checkstyle.sf.net/config_modifiers.html --> | |||
<!-- See http://checkstyle.sf.net/config_modifier.html --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -1,5 +1,5 @@ | |||
distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-5.5.1-all.zip | |||
distributionUrl=https://services.gradle.org/distributions/gradle-5.5.1-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is auto-generated, so :
must probably be kept escaped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it doesn’t work when I escape :
Then, is it better not to fix this one ?-?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it doesn’t work when I escape
What's your error message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it’s not error, it’ s not connected right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "not connected"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm I mean, when I type escaping : , it is just searched on the web. But, when I type https://services.gradle.org/distributions/gradle-5.5.1-all.zip , it is downloaded directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is parsed and interpreted by gradle, some characters are escaped probably to work with same separators accepted by the format, but in the end they are unescaped to retrieve the content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, is it better to use original link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
PR <#927> Signed-off-by: Romain Vimont <[email protected]>
Merged as 7aed5d5. |
I fixed a typo as an annotation of server.c and links of command.c , checkstyle.xml, gradle-wrapper.properties. Please check :)