Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a couple of new command line options. Borderless and window position. #762

Closed
wants to merge 1 commit into from

Conversation

dedosmedia
Copy link
Contributor

I have made some simple changes (I am not C developer, so I tried to do follow your code... not sure my changes are right)

  • Added -B --borderless option. Make the scrcpy window borderless
  • Added -x --pos-x option. Moves the scrcpy window horizontally
  • Added -y --pos-y option. Moves the scrcpy window vertically

* Added -x --pos-x option.  Moves the scrcpy window horizontally
* Added -y --pos-y option.  Moves the scrcpy window vertically
@rom1v
Copy link
Collaborator

rom1v commented Sep 30, 2019

Oh, sorry, I totally forgot about this PR. I will try to review soon.

@dedosmedia
Copy link
Contributor Author

Don't worry. Just some simple commands that I needed for a project, maybe not many people is going to use them.

@rom1v
Copy link
Collaborator

rom1v commented Sep 30, 2019

Out of curiosity, why did you need borderless?

@dedosmedia
Copy link
Contributor Author

dedosmedia commented Sep 30, 2019

I have a PhotoBooth Windows app using a C920 webcam. I am trying to replace the webcam stream with the Android screen. So, I am placing the scrcpy window (TOPMOST) above my photobooth window (which is running fullscreen, behind scrcpy) to display the Android screen as if it were a webcam (I am developing an AR app using AR Core).
I use borderless/position to place the scrcpy window exactly where I need.
Without borderless, it looks ugly, it's evident I have one app placed over another one because of the border/controls, etc.
With borderless scrcpy window looks integrated into my APP's GUI. No one notices there are two apps running at the same time.

I was trying to create a virtual webcam from the scrcpy window, so I could just choose the virtual webcam into my app, but I was not able to do it, so this is the workaround I found. Not the right one, but at least works for me.

BTW, thanks so much for such a useful tool.
I would be happy to donate some money but I think you are not receiving donations as this is something genymobile paid. Anyway, thanks so much! Great effort, great tool and wonderful developer..

@rom1v
Copy link
Collaborator

rom1v commented Sep 30, 2019

With borderless scrcpy window looks integrated into my APP's GUI. No one notices there are two apps running at the same time.

😄 great trick 👍 Thanks for the details.

I would be happy to donate some money but I think you are not receiving donations

Indeed, I do not use any system to receive donations. Maybe some day…

as this is something genymobile paid.

I was employee at Genymobile when I initially developed it (until v1.0~v1.1), so yes, I was paid for developing it. Since then, it's on my free time 😉

Thank you for your message.

@rom1v
Copy link
Collaborator

rom1v commented Nov 3, 2019

Hi,

Sorry for the delay.

I rebased your commit on dev.
I split it into two commits (one for window position, one for borderless).
I renamed --pos-x and --pos-y to --window-x and --window-y (and disabled the "short argument" versions, I want to keep letters free for main options 😉).
For completeness, I also implemented --window-width and --window-height.
I renamed --borderless to --window-borderless.

Here is the resulting branch: window-params.

Please review your modified commits, I'll merge them into dev next week.

@rom1v
Copy link
Collaborator

rom1v commented Nov 15, 2019

Merged into dev.

@rom1v rom1v closed this Nov 15, 2019
@Bubbleioa
Copy link

Thanks a lot, I need borderless window too. Because my phone srceen is a Rounded Rectangle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants