Use getPhysicalDisplayToken if getBuiltInDisplay is not found #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tested it on a Android P Device to check for regressions |
|
Cool, I'm glad you implemented it 👍 Would checking |
|
Yes checking Build.VERSION.SDK_INT should work too. I can update the patch tomorrow with that. |
GulajavaMinistudio
pushed a commit
to javascript-indonesias/scrcpy
that referenced
this pull request
Jun 12, 2019
schwabe
force-pushed
the
fix_586_screen_off_qbeta
branch
2 times, most recently
from
26ace0e to
e46fe51
Compare
|
Okay, updated commit und tested with SDK INT. Still works fine on my Pixel device (Android P) and my Pixel 3 (Q beta 4). This might on betas between but who cares?! |
This makes the -S (screen off) parameter work on Android Q beta 4 Closes Genymobile#586
schwabe
force-pushed
the
fix_586_screen_off_qbeta
branch
from
e46fe51 to
b769083
Compare
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the -S (screen off) parameter work on Android Q beta 4
Closes #586