Enable workarounds by default #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2024
rom1v
added a commit
that referenced
this pull request
Jul 31, 2024
Workarounds were disabled by default, and enabled only on some device or in specific conditions. But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future. In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices [1]. But this is not a problem anymore since commit b8c5853. They also caused problems for audio on Vivo devices [2], but it seems this is not the case anymore [3]. They might also impact an old Nvidia Shield [4], but hopefully this is fixed now. [1]: <#4015 (comment)> [2]: <#3805 (comment)> [3]: <#3805 (comment)> [4]: <#940> PR #5154 <#5154>
rom1v
changed the title
Workarounds were disabled by default, and only enabled for some devices or under specific conditions. But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future. In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices [1]. But this is not a problem anymore since commit b8c5853. They also caused problems for audio on Vivo devices [2], but it seems this is not the case anymore [3]. They might also impact an old Nvidia Shield [4], but hopefully this is fixed now. [1]: <#4015 (comment)> [2]: <#3805 (comment)> [3]: <#3805 (comment)> [4]: <#940> PR #5154 <#5154>
FreedomBen
pushed a commit
to FreedomBen/scrcpy
that referenced
this pull request
Aug 2, 2024
Workarounds were disabled by default, and only enabled for some devices or under specific conditions. But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future. In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices [1]. But this is not a problem anymore since commit b8c5853. They also caused problems for audio on Vivo devices [2], but it seems this is not the case anymore [3]. They might also impact an old Nvidia Shield [4], but hopefully this is fixed now. [1]: <Genymobile#4015 (comment)> [2]: <Genymobile#3805 (comment)> [3]: <Genymobile#3805 (comment)> [4]: <Genymobile#940> PR Genymobile#5154 <Genymobile#5154>
Gottox
pushed a commit
to Gottox/scrcpy
that referenced
this pull request
Sep 29, 2024
Workarounds were disabled by default, and only enabled for some devices or under specific conditions. But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future. In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices [1]. But this is not a problem anymore since commit b8c5853. They also caused problems for audio on Vivo devices [2], but it seems this is not the case anymore [3]. They might also impact an old Nvidia Shield [4], but hopefully this is fixed now. [1]: <Genymobile#4015 (comment)> [2]: <Genymobile#3805 (comment)> [3]: <Genymobile#3805 (comment)> [4]: <Genymobile#940> PR Genymobile#5154 <Genymobile#5154>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workarounds were disabled by default, and enabled only on some device or in specific conditions.
But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future.
In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices(#4015 (comment)). But this is not a problem anymore since commit b8c5853.
They also caused problems for audio on Vivo devices (#3805 (comment)), but it seems this is not the case anymore (#3805 (comment)).
They might also impact an old Nvidia Shield (#940), but hopefully this is fixed now.
Refs #5148.
scrcpy-win64-pr5154.zipSHA-256: 4a0a0941086fbefff4185202519a31b39e159001d494b12b16745f03a024e84