Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clipboard workaround for Honor device #4822

Closed
wants to merge 1 commit into from
Closed

Add clipboard workaround for Honor device #4822

wants to merge 1 commit into from

Conversation

eiyooooo
Copy link
Contributor

@eiyooooo eiyooooo commented Apr 7, 2024

Similar to #3885, but newer version

public ClipData getPrimaryClip(String pkg, String attributionTag, int userId, int deviceId, String stackTraceMsg)

@rom1v
Copy link
Collaborator

rom1v commented Apr 7, 2024

Thank you.

Could you please post your framework.jar?

adb pull /system/framework/framework.jar

@eiyooooo
Copy link
Contributor Author

eiyooooo commented Apr 7, 2024

Could you please post your framework.jar?

framework.zip

rom1v pushed a commit that referenced this pull request Apr 7, 2024
@eiyooooo @rom1v
Add yet another copy-paste workaround
ad8b824 
For some Honor devices.

PR #4822 <#4822>

Signed-off-by: Romain Vimont <[email protected]>
@rom1v
Copy link
Collaborator

rom1v commented Apr 7, 2024 •
edited
Loading

Thank you.

I refactored the current code base to avoid nested try-catch blocks (there are now too many cases for clipboard): d1a0f9b

Then I rebased your commit: ad8b824

Does it look ok to you?

@eiyooooo
Copy link
Contributor Author

eiyooooo commented Apr 7, 2024

Does it look ok to you?

LGTM🫡

This was referenced Jul 17, 2024
Closed
Closed
@rom1v
Copy link
Collaborator

rom1v commented Jul 17, 2024

Oops, sorry, I forgot this PR (and my branch pr4822), and re-implemented it 😕

#5073 (comment)

@rom1v rom1v closed this Jul 17, 2024
@eiyooooo eiyooooo mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eiyooooo @rom1v