Added a new option : -n/--no-window #418

TheCapsLock · 2019-02-01T22:22:54Z

This option allows scrcpy to be run withou showing preview window : we can now use
scrcpy only for screen recording as an example

This option allows scrcpy to be run headless : we can now use scrcpy only for screen recording as an example

rom1v

Thank you for your contribution.

I like the idea to add such a flag. Maybe it could skip a lot more code (do not decode frame, do not initialize SDL…).

I'll test it probably after the FOSDEM.

rom1v · 2019-02-01T23:31:11Z

app/src/scrcpy.c

-                    screen_show_window(&screen);
+                    if (!no_window) {
+                        screen_show_window(&screen);
+                    }


I think you can skip code far earlier, you may not even need to initialize SDL nor decode frames at all if you have no window.

rom1v · 2019-02-01T23:31:31Z

app/src/main.c

@@ -209,6 +215,7 @@ static SDL_bool parse_args(struct args *args, int argc, char *argv[]) {
        {"bit-rate",     required_argument, NULL, 'b'},
        {"crop",         required_argument, NULL, 'c'},
        {"fullscreen",   no_argument,       NULL, 'f'},
+        {"no-window",   no_argument,       NULL, 'n'},


done; sorry for that

rom1v · 2019-02-01T23:32:11Z

app/src/main.c

@@ -219,7 +226,7 @@ static SDL_bool parse_args(struct args *args, int argc, char *argv[]) {
        {NULL,           0,                 NULL, 0  },
    };
    int c;
-    while ((c = getopt_long(argc, argv, "b:c:fhm:p:r:s:tv", long_options, NULL)) != -1) {
+    while ((c = getopt_long(argc, argv, "b:c:fnhm:p:r:s:tv", long_options, NULL)) != -1) {


(please keep the alphabetical order, ditto above and below)

npes87184 · 2019-02-02T01:39:23Z

Hi,

I have two simple recommendations for this patch:

Please provide either a log in console or a toast in android side, so that we can know that the scrcpy finishes its initialization.
Use -n alone doesn’t make sense now. IMO, we can return error if -n and -r don’t exist simultaneously.

Thanks,
Yu-Chen

npes87184 · 2019-02-02T01:43:51Z

app/src/main.c

@@ -232,6 +239,9 @@ static SDL_bool parse_args(struct args *args, int argc, char *argv[]) {
            case 'f':
                args->fullscreen = SDL_TRUE;
                break;
+            case 'n':
+                args->no_window = SDL_TRUE;


Missing default value or an initialization. See main.c

TheCapsLock · 2019-02-05T23:50:29Z

* Use -n alone doesn’t make sense now. IMO, we can return error if -n and -r don’t exist simultaneously.

Added an error message if nor -n is provided without -r

TheCapsLock · 2019-02-06T00:12:49Z

Thank you for your contribution.

I like the idea to add such a flag. Maybe it could skip a lot more code (do not decode frame, do not initialize SDL…

I'll test it probably after the FOSDEM.

Thanks a lot for that ; I tried some combinations but did not get something better yet ; if you have clear idea in mind may I let you look at this specific topic ?

TheCapsLock · 2019-02-06T08:46:13Z

* Please provide either a log in console or a toast in android side, so that we can know that the scrcpy finishes its initialization.

I've added a log message, thank you for this clever recommendation

rom1v · 2019-02-17T16:03:39Z

if you have clear idea in mind may I let you look at this specific topic ?

Yes, it requires some refactor beforehand: the decoder must be separated from the "video stream receiver", so that we can skip the decoder completely (we don't need to decode the video at all if there is no window). I will try to work on it so that it is included in the next version.

TheCapsLock · 2019-02-18T08:48:08Z

if you have clear idea in mind may I let you look at this specific topic ?

Yes, it requires some refactor beforehand: the decoder must be separated from the "video stream receiver", so that we can skip the decoder completely (we don't need to decode the video at all if there is no window). I will try to work on it so that it is included in the next version.

Great to here this kind of news :) thanks a lot!

Disable decoder, screen (display), file_handler and controller when --no-window is requested. <#418>

rom1v · 2019-03-02T17:42:37Z

I refactored to split the decoder into stream+decoder: e6e011b.
Then I rebased your commit (but removed the part which disabled the window after decoding): 421a114.
Then I disabled everything useless when --no-window is passed: 89812e4.

It's on dev branch for now.

I'm closing as merged (even if github does see it as merged).

Disable decoder, screen (display), file_handler and controller when --no-window is requested. <#418>

rom1v · 2019-03-02T21:59:35Z

I have renamed the option -N/--no-display.

The description of scrcpy is "Display and control your Android device".

We want an option to disable display, another one to disable control, so I also implemented -n/--no-control.

TheCapsLock · 2019-03-04T11:18:04Z

Tested on multiple devices, seems to work great, thanks ❤️

Gapplay · 2019-03-22T15:27:04Z

@rom1v is possible to show fps when No-display is enabled?

rom1v · 2019-03-22T16:03:50Z

Currently, no.

A command line option (--print-fps) could be added to enable it on start.

rom1v · 2019-03-22T16:22:17Z

@Gapplay Please open a new issue for it, to not forget it.

Added a new option : -n/--no-window

8d4ff03

This option allows scrcpy to be run headless : we can now use scrcpy only for screen recording as an example

rom1v reviewed Feb 1, 2019

View reviewed changes

npes87184 reviewed Feb 2, 2019

View reviewed changes

Fixed some issues mentioned in comments

3eaf39f

Added a log message telling when scrcpy is initialized

0ad9dc1

rom1v added a commit that referenced this pull request Mar 2, 2019

Implement the --no-window flag

8c95835

Disable decoder, screen (display), file_handler and controller when --no-window is requested. <#418>

rom1v closed this Mar 2, 2019

rom1v added a commit that referenced this pull request Mar 2, 2019

Implement the --no-window flag

89812e4

Disable decoder, screen (display), file_handler and controller when --no-window is requested. <#418>

Gapplay mentioned this pull request Mar 22, 2019

Command to show FPS #468

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a new option : -n/--no-window #418

Added a new option : -n/--no-window #418

TheCapsLock commented Feb 1, 2019 •

edited

Loading

rom1v left a comment •

edited

Loading

rom1v Feb 1, 2019

rom1v Feb 1, 2019

TheCapsLock Feb 5, 2019

rom1v Feb 1, 2019

TheCapsLock Feb 5, 2019

npes87184 commented Feb 2, 2019

npes87184 Feb 2, 2019

TheCapsLock Feb 5, 2019

TheCapsLock commented Feb 5, 2019

TheCapsLock commented Feb 6, 2019

TheCapsLock commented Feb 6, 2019

rom1v commented Feb 17, 2019

TheCapsLock commented Feb 18, 2019

rom1v commented Mar 2, 2019 •

edited

Loading

rom1v commented Mar 2, 2019

TheCapsLock commented Mar 4, 2019

Gapplay commented Mar 22, 2019

rom1v commented Mar 22, 2019

rom1v commented Mar 22, 2019

Added a new option : -n/--no-window #418

Added a new option : -n/--no-window #418

Conversation

TheCapsLock commented Feb 1, 2019 • edited Loading

rom1v left a comment • edited Loading

Choose a reason for hiding this comment

rom1v Feb 1, 2019

Choose a reason for hiding this comment

rom1v Feb 1, 2019

Choose a reason for hiding this comment

TheCapsLock Feb 5, 2019

Choose a reason for hiding this comment

rom1v Feb 1, 2019

Choose a reason for hiding this comment

TheCapsLock Feb 5, 2019

Choose a reason for hiding this comment

npes87184 commented Feb 2, 2019

npes87184 Feb 2, 2019

Choose a reason for hiding this comment

TheCapsLock Feb 5, 2019

Choose a reason for hiding this comment

TheCapsLock commented Feb 5, 2019

TheCapsLock commented Feb 6, 2019

TheCapsLock commented Feb 6, 2019

rom1v commented Feb 17, 2019

TheCapsLock commented Feb 18, 2019

rom1v commented Mar 2, 2019 • edited Loading

rom1v commented Mar 2, 2019

TheCapsLock commented Mar 4, 2019

Gapplay commented Mar 22, 2019

rom1v commented Mar 22, 2019

rom1v commented Mar 22, 2019

TheCapsLock commented Feb 1, 2019 •

edited

Loading

rom1v left a comment •

edited

Loading

rom1v commented Mar 2, 2019 •

edited

Loading