Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing on Windows with winget #4005

Closed
wants to merge 1 commit into from
Closed

Installing on Windows with winget #4005

wants to merge 1 commit into from

Conversation

TrangOul
Copy link
Contributor

No description provided.

rom1v pushed a commit that referenced this pull request May 17, 2023
@TrangOul @rom1v
Document installation via winget on Windows
686f140 
PR #4005 <#4005>
Refs #1444 <#1444>
Refs #3932 <#3932>

Signed-off-by: Romain Vimont <[email protected]>
rom1v
rom1v reviewed May 17, 2023
View reviewed changes
doc/windows.md

```bash
winget install scrcpy
winget install adb # if you don't have it yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adb available via Winget? I did not found it in https://github.com/microsoft/winget-pkgs

Copy link
Contributor

@yume-chan yume-chan May 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

winget install scrcpy should be enough, it uses the official Windows release which already includes adb.exe.

adb does exist in winget repository, but can only be installed by its ID:

winget install Google.PlatformTools

EDIT: I verified it will use the bundled adb.exe, however the execution alias (symlink) doesn't work

image

image

Maybe an issue with winget itself, or the symlink confused scrcpy making it can't find its dlls?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I will just remove the line about adb.

Do you know if it is necessary to install adb separately with scoop and chocolatey package managers, or if the scrcpy package is sufficient?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I don't use other package managers.

rom1v pushed a commit that referenced this pull request May 17, 2023
@TrangOul @rom1v
Document installation via winget on Windows
c4461f9 
PR #4005 <#4005>
Refs #1444 <#1444>
Refs #3932 <#3932>

Signed-off-by: Romain Vimont <[email protected]>
rom1v pushed a commit that referenced this pull request May 17, 2023
@TrangOul @rom1v
Document installation via winget on Windows
958f224 
PR #4005 <#4005>
Refs #1444 <#1444>
Refs #3932 <#3932>

Signed-off-by: Romain Vimont <[email protected]>
@rom1v
Copy link
Collaborator

rom1v commented May 17, 2023

Thank you, merged: 958f224

(I removed the line about adb)

@rom1v rom1v closed this May 17, 2023
This was referenced May 17, 2023
Closed
Closed
@TrangOul
Copy link
Contributor Author

My bad about adb, thanks for correcting that!

@TrangOul TrangOul deleted the patch-1 branch May 18, 2023 09:01
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yume-chan yume-chan yume-chan left review comments

@rom1v rom1v rom1v left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrangOul @rom1v @yume-chan