Notify ScreenEncoder when a folding event occurs #3979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoPi
commented
May 7, 2023
| @Override | ||
| public void onFoldChanged(int displayId) { | ||
| // TODO: rename rotationChanged to something like displayChanged? To discuss with @rom1v | ||
| rotationChanged.set(true); |
There was a problem hiding this comment.
@rom1v Here I guess this variable could be renamed? Or do we need two variables?
|
Awesome, I didn't know there was such a fold change event. I will review in details later (I have other things to implement/fix first). In any case, I will merge it for the next release (2.1). Thank you. |
rom1v
pushed a commit
that referenced
this pull request
May 29, 2023
Handle folding event the same way as rotation events. Fixes #3960 <#3960> PR #3979 <#3979> Signed-off-by: Romain Vimont <[email protected]>
|
I rebased on current I pushed to |
rom1v
pushed a commit
that referenced
this pull request
Jun 1, 2023
Handle folding event the same way as rotation events. Fixes #3960 <#3960> PR #3979 <#3979> Signed-off-by: Romain Vimont <[email protected]>
|
Merged: 24999d0 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
It's been a while since my last contribution, it's a pleasure to be able to contribute again to this amazing project!
I'm a lucky owner of a foldable phone ( Z fold 4 ) and I've seen that scrcpy does not handle the fold events ( The SDL Window does not update its size when I bend my phone ).
I just fixed this issue ( it is implemented the same way as RotationWatcher ).
Btw I have a little concern about the naming of the boolean
ScreenEncoder.rotationChangedwhich may not have a good name after this PR.