Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't concatenate strings in cross-platform config #3546

Closed
wants to merge 1 commit into from
Closed

Can't concatenate strings in cross-platform config #3546

wants to merge 1 commit into from

Conversation

npes87184
Copy link
Contributor

Please see mesonbuild/meson#3878

Signed-off-by: Yu-Chen Lin [email protected]

@rom1v
Copy link
Collaborator

rom1v commented Oct 22, 2022

Which meson version?

@npes87184
Copy link
Contributor Author

meson version 0.53.2 with the following error message.

platform-tools-33.0.1 found
SDL2-2.0.22 found
ffmpeg-win64-5.0.1 found
libusb-1.0.26 found
[ -d "build-win64" ] || ( mkdir "build-win64" && \
        meson "build-win64" \
                --cross-file cross_win64.txt \
                --buildtype release --strip -Db_lto=true \
                -Dcompile_server=false \
                -Dportable=true )

ERROR: Malformed value in cross file variable prebuilt_libusb.
make: *** [release.mk:87: build-win64] Error 1

rom1v pushed a commit that referenced this pull request Oct 23, 2022
@npes87184 @rom1v
Avoid string concatenation in crossfiles
d71587e 
This feature is not supported on older meson versions:

    ERROR: Malformed value in cross file variable prebuilt_libusb.

Refs <mesonbuild/meson#3878>
PR #3546 <#3546>

Signed-off-by: Yu-Chen Lin <[email protected]>
Signed-off-by: Romain Vimont <[email protected]>
@rom1v
Copy link
Collaborator

rom1v commented Oct 23, 2022

Thank you 👍

I added the same change for cross_win32.txt, and merged into dev: d71587e.

@rom1v rom1v closed this Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npes87184 @rom1v