Support smooth scrolling on notebook touchpads. #3369

yume-chan · 2022-07-06T05:36:21Z

HID mode doesn't support this smooth scrolling, because sending fractional scrolling distance over standard HID mouse protocol seems complicated. I may investigate more in the future (plus horizontal scrolling support).

Only tested on Windows with both mouse and touchpad.

In bash, the variable is set using "export".

Document how to set environment variables from the terminal for bash, cmd and PowerShell.

app/src/control_msg.c

yume-chan · 2022-07-06T05:38:42Z

app/src/input_manager.c

+      // up is positive
+      vscroll = CLAMP(event->preciseY, -1.0f, 1.0f);
+    } else {
+      hscroll = CLAMP(-event->x, -1, 1);


Nowadays the horizontal scrolling is actually inverted, so negated x and preciseX.

Hmmm, looks suspicious. See #966 (comment)

I have seen that issue before, but this also happens to mouses with horizontal scrolling wheels.

Windows also has a touchpad scrolling direction setting, but whatever it was set, vertical scrolling is always correct and horizontal scrolling is always inverted.

I will test on a mac tomorrow.

Confirmed it's also inverted on macOS when using a mouse. My mac doesn't has touchpad so can't test that.

What's the value of event->direction in each case?

Concretely, could you list for each case (mouse/touchpad on windows/macOS):

event->direction

event->x

event->y

"inverted" or "not inverted"

cc @fsw0422 as the author of #966 (I do not want to break the fix for #966)

I won't be with my mac until Friday, will try that later.

So that it can be reused for other fields. PR #3369 <#3369>

Since SDL 2.0.18, the amount scrolled horizontally or vertically is exposed as a float (between 0 and 1). XX DO NOT MERGE (YET) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX Remaining problem (?) before merging: the x and y value are clamped to [0; 1], so if on some platforms a scroll event could be triggered with a value greater than 1 or lower than -1, it is not forwarded correctly anymore (this is the case both for the int or float versions). XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX Refs <https://wiki.libsdl.org/SDL_MouseWheelEvent> Fixes #3363 <#3363> PR #3369 <#3369> Signed-off-by: Romain Vimont <[email protected]>

Since SDL 2.0.18, the amount scrolled horizontally or vertically is exposed as a float (between 0 and 1). Forward a precise value to the Android device when possible. Refs <https://wiki.libsdl.org/SDL_MouseWheelEvent> Fixes #3363 <#3363> PR #3369 <#3369> Signed-off-by: Romain Vimont <[email protected]>

rom1v · 2022-07-24T14:52:22Z

Thank you 👍 (and sorry for the delay).

I rebased on dev (and squashed your 2 commits), and made the following changes:

extracted a function fixedPointToFloat() used for pressure as a preliminary commit before your changes;
use this function in your commits;
remove the inversion of horizontal scrolling (it looks suspicious to me, cf In Mac OS, I think the natural scrolling doesn't work #966 (comment), please take a look and confirm that it works as expected for you);
used conditional compilation for SDL_VERSION_ATLEAST() (otherwise it would not compile with an older SDL version).

I was first annoyed by the CLAMP() between -1 and 1, but the Android side expects a value in this range: AXIS_VSCROLL, so it's better to clamp anyway (even if SDL could trigger values outside this range).

I could not test since on my computer, only -1 or +1 values are generated.

Please review and test this branch: pr3369.1.

For some reason, '%g' does not work correctly with MinGW. Refs #3369 <#3369>

For some reason, '%g' does not work correctly with MinGW. Refs #3369 <#3369> PR #3399 <#3399>

PR #3369 <#3369>

It will allow to expose more binary util functions not related to buffers. PR #3369 <#3369>

PR #3369 <#3369>

To encode float values between -1 and 1. PR #3369 <#3369>

Since SDL 2.0.18, the amount scrolled horizontally or vertically is exposed as a float (between 0 and 1). Forward a precise value to the Android device when possible. Refs <https://wiki.libsdl.org/SDL_MouseWheelEvent> Fixes #3363 <#3363> PR #3369 <#3369> Signed-off-by: Romain Vimont <[email protected]>

rom1v · 2022-08-03T21:53:06Z

I changed to encode as a signed integer (with a more natural two's complement):

-1.0f → 0x8000
-0.5f → 0xC000
0.0f → 0x0000
0.5f → 0x4000
1.0f → 0x7FFF

I added the necessary util functions and unit tests beforehand, then adapted your commit to use them.

Please review and test pr3369.3.

Thank you 😉

rom1v · 2022-08-16T22:01:57Z

@yume-chan Did you have a change to test/review? (It's not urgent)

yume-chan · 2022-08-18T12:52:13Z

Sorry, I'm still busy working on another project. I always have this on my todo list and will report back once that's finished.

PR #3369 <#3369>

It will allow to expose more binary util functions not related to buffers. PR #3369 <#3369>

PR #3369 <#3369>

To encode float values between -1 and 1. PR #3369 <#3369>

Since SDL 2.0.18, the amount scrolled horizontally or vertically is exposed as a float (between 0 and 1). Forward a precise value to the Android device when possible. Refs <https://wiki.libsdl.org/SDL_MouseWheelEvent> Fixes #3363 <#3363> PR #3369 <#3369> Signed-off-by: Romain Vimont <[email protected]>

rom1v · 2022-08-28T13:46:45Z

I merged into dev. Everything looks good to me.

metayan · 2022-09-02T11:25:05Z

This works great on my Mac, both with touchpad and mouse.
The scrolling is much nicer now.

The version should probably be bumped, because of the incompatible server/client.
When I tried to scroll with mismatched server, I got a lot of

[server] WARN: Unknown event type: -116

(with the number varying for different runs) and then scrcpy would become completely unresponsive. (That the scrolling didn't work was expected, but a little surprising that it didn't recover.)

Also, had to change PLATFORM and BUILD_TOOLS from 31 to 33 in server/build_without_gradle.sh, because otherwise I kept getting

[server] INFO: Device: Sony G8441 (Android 9)
[server] ERROR: Exception on thread Thread[main,5,main]
java.lang.AssertionError: java.lang.NullPointerException: 
 Attempt to invoke virtual method
 'java.lang.reflect.Method java.lang.Class.getMethod(java.lang.String, java.lang.Class[])'
 on a null object reference
        at com.genymobile.scrcpy.wrappers.WindowManager.registerRotationWatcher(WindowManager.java:108)
        at com.genymobile.scrcpy.Device.<init>(Device.java:85)
        at com.genymobile.scrcpy.Server.scrcpy(Server.java:65)
        at com.genymobile.scrcpy.Server.main(Server.java:335)
        at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
        at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:340)
Caused by: java.lang.NullPointerException:
 Attempt to invoke virtual method
 'java.lang.reflect.Method java.lang.Class.getMethod(java.lang.String, java.lang.Class[])'
 on a null object reference
        at com.genymobile.scrcpy.wrappers.WindowManager.registerRotationWatcher(WindowManager.java:102)
        ... 5 more
2022-09-02 13:12:05.549 scrcpy[48321:5695314] DEBUG: Interrupting socket
2022-09-02 13:12:05.549 scrcpy[48321:5695314] DEBUG: Server disconnected
2022-09-02 13:12:05.549 scrcpy[48321:5695314] DEBUG: Server terminated

yume-chan · 2022-09-02T11:45:30Z

@metayan Thanks for the verification!

In addition, can you verify does horizontal scrolling works (not flipped) on both touchpad and mouse (if you have a mouse with horizonal scroll wheel)? You can open the browser app on your phone and pinch out to zoom in, then scroll horizontally.

The version should probably be bumped

It will, when the new version is released.

then scrcpy would become completely unresponsive

That's expected. The packet size changed, so after one mismatched packet, the whole stream becomes out of sync.

Also, had to change PLATFORM and BUILD_TOOLS from 31 to 33

This looks unrelated to this PR, maybe you want to open a new issue for further investigation.

metayan · 2022-09-02T12:06:28Z

@metayan Thanks for the verification!

In addition, can you verify does horizontal scrolling works (not flipped) on both touchpad and mouse (if you have a mouse with horizonal scroll wheel)? You can open the browser app on your phone and pinch out to zoom in, then scroll horizontally.

It is "flipped" on the touchpad.
With "Scroll direction: Natural" set in preferences, the vertical scroll follows the fingers, but the horizontal moves in the opposite direction.

I don't have a mouse with horizontal scroll wheel.

The version should probably be bumped

It will, when the new version is released.

Might be an idea to bump it immediately when changing the protocol, so anyone building from source will notice the mismatch right away. Your choice, of course. ;)

Also, had to change PLATFORM and BUILD_TOOLS from 31 to 33

This looks unrelated to this PR, maybe you want to open a new issue for further investigation.

Seems so. Will do.

rom1v and others added 4 commits June 17, 2022 08:36

Fix environment variable configuration in FAQ

a83c3e3

In bash, the variable is set using "export".

Document envvars for all platforms

ed84e18

Document how to set environment variables from the terminal for bash, cmd and PowerShell.

Use fractional scroll delta

1c3e33c

handle float scroll distance in protocol level

0889a66

yume-chan commented Jul 6, 2022

View reviewed changes

app/src/control_msg.c Show resolved Hide resolved

yume-chan commented Jul 6, 2022

View reviewed changes

app/src/control_msg.c Show resolved Hide resolved

yume-chan commented Jul 6, 2022

View reviewed changes

rom1v added a commit that referenced this pull request Jul 24, 2022

Extract conversion from fixed-point u16 to float

72ff957

So that it can be reused for other fields. PR #3369 <#3369>

yume-chan changed the base branch from master to dev July 24, 2022 15:18

rom1v added a commit that referenced this pull request Jul 26, 2022

Replace '%g' by '%f' as printf format

64fe745

For some reason, '%g' does not work correctly with MinGW. Refs #3369 <#3369>

rom1v mentioned this pull request Jul 26, 2022

Replace '%g' by '%f' as printf format #3399

Merged

rom1v added a commit that referenced this pull request Aug 3, 2022

Replace '%g' by '%f' as printf format

d23b3e8

For some reason, '%g' does not work correctly with MinGW. Refs #3369 <#3369> PR #3399 <#3399>

rom1v added a commit that referenced this pull request Aug 3, 2022

Move toUnsigned() to a Binary util class

a964825

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 3, 2022

Extract conversion from u16 fixed-point to float

185c7e8

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 3, 2022

Add unit test for float decoding

2489987

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 3, 2022

Rename buffer_util.h to binary.h

39fe6b5

It will allow to expose more binary util functions not related to buffers. PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 3, 2022

Extract conversion from float to u16 fixed-point

7c9557e

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 3, 2022

Add unit test for float encoding

4f9288c

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 3, 2022

Add conversion from float to fixed-point i16

27bbec7

To encode float values between -1 and 1. PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 28, 2022

Move toUnsigned() to a Binary util class

5b8e9aa

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 28, 2022

Extract conversion from u16 fixed-point to float

3848ce8

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 28, 2022

Add unit test for float decoding

136ab8c

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 28, 2022

Rename buffer_util.h to binary.h

041cdf6

It will allow to expose more binary util functions not related to buffers. PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 28, 2022

Extract conversion from float to u16 fixed-point

fd3483c

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 28, 2022

Add unit test for float encoding

1ab6c19

PR #3369 <#3369>

rom1v added a commit that referenced this pull request Aug 28, 2022

Add conversion from float to fixed-point i16

1f138ae

To encode float values between -1 and 1. PR #3369 <#3369>

rom1v closed this Aug 28, 2022

rom1v mentioned this pull request Aug 28, 2022

Handle high-precision scrolling when using notebook touchpads #3363

Closed

1 task

rom1v mentioned this pull request Sep 2, 2022

Server fails when built with SDK < 33 on macOS #3481

Closed

2 tasks

yume-chan mentioned this pull request Oct 18, 2022

@yume-chan/scrcpy documentation for standalone package yume-chan/ya-webadb#455

Closed

yume-chan deleted the float-scroll branch January 27, 2023 21:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support smooth scrolling on notebook touchpads. #3369

Support smooth scrolling on notebook touchpads. #3369

yume-chan commented Jul 6, 2022 •

edited

Loading

yume-chan Jul 6, 2022

rom1v Jul 24, 2022

yume-chan Jul 24, 2022 •

edited

Loading

yume-chan Jul 25, 2022 •

edited

Loading

rom1v Jul 25, 2022

yume-chan Jul 26, 2022

rom1v commented Jul 24, 2022 •

edited

Loading

rom1v commented Aug 3, 2022

rom1v commented Aug 16, 2022

yume-chan commented Aug 18, 2022

rom1v commented Aug 28, 2022

metayan commented Sep 2, 2022

yume-chan commented Sep 2, 2022

metayan commented Sep 2, 2022

Support smooth scrolling on notebook touchpads. #3369

Support smooth scrolling on notebook touchpads. #3369

Conversation

yume-chan commented Jul 6, 2022 • edited Loading

yume-chan Jul 6, 2022

Choose a reason for hiding this comment

rom1v Jul 24, 2022

Choose a reason for hiding this comment

yume-chan Jul 24, 2022 • edited Loading

Choose a reason for hiding this comment

yume-chan Jul 25, 2022 • edited Loading

Choose a reason for hiding this comment

rom1v Jul 25, 2022

Choose a reason for hiding this comment

yume-chan Jul 26, 2022

Choose a reason for hiding this comment

rom1v commented Jul 24, 2022 • edited Loading

rom1v commented Aug 3, 2022

rom1v commented Aug 16, 2022

yume-chan commented Aug 18, 2022

rom1v commented Aug 28, 2022

metayan commented Sep 2, 2022

yume-chan commented Sep 2, 2022

metayan commented Sep 2, 2022

yume-chan commented Jul 6, 2022 •

edited

Loading

yume-chan Jul 24, 2022 •

edited

Loading

yume-chan Jul 25, 2022 •

edited

Loading

rom1v commented Jul 24, 2022 •

edited

Loading