Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt event injection to Android 13 #3190

Closed
wants to merge 2 commits into from
Closed

Adapt event injection to Android 13 #3190

wants to merge 2 commits into from

Conversation

rom1v
Copy link
Collaborator

@rom1v rom1v commented Apr 16, 2022

Using the "input" service results in a permission error in Android 13.

Use the InputManager instance (retrieved by InputManager.getInstance()) instead.

Fixes #3186

rom1v added 2 commits April 16, 2022 09:25
Using the "input" service results in a permission error in Android 13.

Use the InputManager instance (retrieved by InputManager.getInstance())
instead.

Fixes #3186 <#3186>
The previous commit replaced the IInterface instance (the "input"
service) by the InputManager instance (retrieved by
InputManager.getInstance()).

Both define an "injectInputEvent" method, but the alternate version
(probably) does not concern the InputManager.

This reverts commit b7a0627.
@rom1v
Copy link
Collaborator Author

rom1v commented Apr 16, 2022

@thomasrebele Could you please test that it does not break #2946/#2250?

Here is a binary (to replace in v1.23 release):

  • scrcpy-server sha256:346ef862cc9558f27cd1ca8a461bd31e952ae3b506fbd0b8bc83516c38dd3f96

@rom1v rom1v changed the title Android13 Adapt event injection to Android 13 Apr 16, 2022
rom1v added a commit that referenced this pull request Apr 22, 2022
Using the "input" service results in a permission error in Android 13.

Use the InputManager instance (retrieved by InputManager.getInstance())
instead.

Fixes #3186 <#3186>
PR #3190 <#3190>
rom1v added a commit that referenced this pull request Apr 22, 2022
The previous commit replaced the IInterface instance (the "input"
service) by the InputManager instance (retrieved by
InputManager.getInstance()).

Both define an "injectInputEvent" method, but the alternate version
(probably) does not concern the InputManager.

This reverts commit b7a0627.

PR #3190 <#3190>
@rom1v
Copy link
Collaborator Author

rom1v commented Apr 22, 2022

Merged:

@rom1v rom1v closed this Apr 22, 2022
rom1v added a commit that referenced this pull request Apr 22, 2022
Using the "input" service results in a permission error in Android 13.

Use the InputManager instance (retrieved by InputManager.getInstance())
instead.

Fixes #3186 <#3186>
PR #3190 <#3190>
rom1v added a commit that referenced this pull request Apr 22, 2022
The previous commit replaced the IInterface instance (the "input"
service) by the InputManager instance (retrieved by
InputManager.getInstance()).

Both define an "injectInputEvent" method, but the alternate version
(probably) does not concern the InputManager.

This reverts commit b7a0627.

PR #3190 <#3190>
@thomasrebele
Copy link
Contributor

@thomasrebele Could you please test that it does not break #2946/#2250?

I've compiled latest commit to branch dev (6a4a4a2). Seems to work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants