Mark sockets as non-inheritable on Windows #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to communicate with a child process via stdin, stdout and stderr, the CreateProcess() parameter bInheritHandles must be set to TRUE. But this causes *all* handles to be inherited, including sockets. One possibility could be to use an extended API to set extra attributes on process creation: - <https://stackoverflow.com/a/28185363/1987178> - <https://devblogs.microsoft.com/oldnewthing/20111216-00/?p=8873> But it seems that this API is not available on MinGW (it does not compile). As an alternative, explicitly mark all sockets as non-inheritable. Fixes #2779 <#2779>
rom1v
force-pushed
the
fix_inherit_handles
branch
from
7fef713 to
020b351
Compare
|
Will do differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to communicate with a child process via stdin, stdout and
stderr, the CreateProcess() parameter bInheritHandles must be set to
TRUE. But this causes all handles to be inherited, including sockets.
One possibility could be to use an extended API to set extra attributes
on process creation:
But it seems that this API is not available on MinGW (it does not
compile).
As an alternative, explicitly mark all sockets as non-inheritable.
Fixes #2779
Replace these binaries in your v1.20 release:
scrcpy.exesha256:6ab57110d07088e0793c1e1a8d2caabdc5811ade54bfeb5646778f6563cd7169scrcpy-serversha256:b20aee4951f99b060c4a44000ba94de973f9604758ef62beb253b371aad3df34