Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SDL (2.0.14) Adb (31.0.3) for Windows #2582

Closed
wants to merge 8 commits into from

Conversation

nkh0472
Copy link
Contributor

@nkh0472 nkh0472 commented Aug 24, 2021

They are the latest versions.
ADB 31.0.2 --> 31.0.3
SDL2 2.0.14 --> 2.0.16


Maybe there is some better solution to fetch the latest deps:

For ADB, we can use curl -L -O https://dl.google.com/android/repository/platform-tools-latest-windows.zip, this only affectS ./prebuilt-deps/Makefile.

For SDL2, I'm not sure how to do this, but at least we can use some kind of variate, so we only need to change the dictionary name in one file (like in ./prebuilt-deps/Makefile), instead of in 4 files (including ./prebuilt-deps/Makefile, ./cross_win32.txt, ./cross_win64.txt, ./release.mk).

Additionally, the situation about FFmpeg is more complicated, I'll open a new PR to describe it.

@nkh0472 nkh0472 changed the base branch from master to dev August 24, 2021 04:46
@rom1v
Copy link
Collaborator

rom1v commented Aug 24, 2021

They are the latest versions.
ADB 31.0.2 --> 31.0.3
SDL2 2.0.14 --> 2.0.16

Thank you.

I use to upgrade them just before a release (because in practice this is when it matters).

I may accept bumping versions at other times though. However, could you please rebase properly on dev, and create one commit for the adb upgrade and one for the SDL upgrade? (if the SDL upgrade is split in several commits, it will break on git bisect)

Example of previous upgrades:

Maybe there is some better solution to fetch the latest deps:

I want to reference a specific version, so that a release from an old version can be re-created with the same dependencies (ok, it's only a best-medium effort, because I don't archive all the downloaded binaries). And bump the versions only after testing them.

@nkh0472 nkh0472 marked this pull request as draft August 25, 2021 03:10
@nkh0472
Copy link
Contributor Author

nkh0472 commented Aug 25, 2021

Done in #2588 and #2589.

@nkh0472 nkh0472 closed this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants