Press 2x extra mouse button to open settings #2264
Conversation
Allows shortcuts such as: CTRL + n + n to open the settings panel
The collapsing action collapses the panel whichever is open. Even in-app panels
Now it gets a parameter. However, it can be null https://code.yawk.at/android/android-9.0.0_r35/android/app/StatusBarManager.java#android.app.StatusBarManager%23expandSettingsPanel(java.lang.String) For now, I don't have android 10's but it's probably a version without the noargument method
brunoais
force-pushed
the
2xExtraButton-OpenSettings
branch
from
eb3f637 to
9f39fca
Compare
Double-click on extra mouse button to open the settings panel (a single-click opens the notification panel). This is consistent with the keyboard shortcut MOD+n+n. PR #2264 <#2264> Signed-off-by: Romain Vimont <[email protected]>
Double-click on extra mouse button to open the settings panel (a single-click opens the notification panel). This is consistent with the keyboard shortcut MOD+n+n. PR #2264 <#2264> Signed-off-by: Romain Vimont <[email protected]>
Double-click on extra mouse button to open the settings panel (a single-click opens the notification panel). This is consistent with the keyboard shortcut MOD+n+n. PR #2264 <#2264> Signed-off-by: Romain Vimont <[email protected]>
|
Merged into |
|
A minor inconsistency: with the keyboard shortcut, the settings panel is expanded regardless of the delay between the first MOD+n and the second. With the mouse, it only works with a double-click. Maybe it should work with a longer delay too? What do you think? |
|
Sounds good to me. That feature acting consistent between both ways is better. |
|
OK, I noticed this when testing before releasing v1.18. But it's minor, so I still released. It can be fixed later 😉 |
(Or maybe the keyboard shortcut should only work for a short delay (like a double click), I don't know which is better.) |
|
After thinking for a while. I think both should have the reset after a short delay. |
Requires #2260