Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1572/turn on screen when exit #1576

Closed
wants to merge 2 commits into from
Closed

1572/turn on screen when exit #1576

wants to merge 2 commits into from

Conversation

brunoais
Copy link
Contributor

@brunoais brunoais commented Jul 8, 2020 •
edited
Loading

This was more straightforward than I expected.
Does this seem to be correctly done?

closes #1572

@brunoais brunoais changed the base branch from master to dev July 8, 2020 16:48
@brunoais brunoais force-pushed the 1572/TurnOnScreenWhenExit branch from 77b0d12 to 1ce9a82 Compare July 8, 2020 17:26
rom1v pushed a commit that referenced this pull request Jul 9, 2020
@brunoais @rom1v
Restore power mode to normal on cleanup
30714ab 
This avoids to let the device screen turned off (as enabled by Ctrl+o or
--turn-screen-off).

PR #1576 <#1576>
Fixes #1572 <#1572>
@rom1v
Copy link
Collaborator

rom1v commented Jul 9, 2020

Does this seem to be correctly done?

Yes, thank you 👍 It works great.

I did the following changed:

  • squash your 2 commits
  • rebase on current dev
  • rename scheduleScreenOn to restoreNormalPowerMode (there is no scheduling here)
  • moved if (restoreNormalPowerMode) outside the other if-block (there is no need to create a ServiceManager for that option)

Please review: pr1576 😉

@brunoais
Copy link
Contributor Author

brunoais commented Jul 9, 2020 •
edited
Loading

LGTM 👍
Anything else I need to do?

@rom1v
Copy link
Collaborator

rom1v commented Jul 9, 2020

Thank you. Merged into dev: 30714ab 👍

@rom1v rom1v closed this Jul 9, 2020
@rom1v rom1v mentioned this pull request Jul 9, 2020
Closed
@rom1v rom1v mentioned this pull request Jul 19, 2020
Open
2 tasks
@rom1v rom1v mentioned this pull request Aug 12, 2020
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoais @rom1v