Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts to rotate display #1274

Closed
wants to merge 1 commit into from
Closed

Add shortcuts to rotate display #1274

wants to merge 1 commit into from

Conversation

rom1v
Copy link
Collaborator

@rom1v rom1v commented Apr 7, 2020

Add Ctrl+Left and Ctrl+Right shortcuts to rotate the scrcpy window.

Contrary to --lock-video-orientation (#1151), the rotation has no impact on recording, and can be changed dynamically (and immediately).

This provides an alternative solution for #218.

There are now 3 different (cumulative) rotations:

  • Ctrl+r to request the device to rotate between portrait and landscape
  • --lock-video-orientation to force a mirroring/recording orientation
  • Ctrl+ and Ctrl+ to rotate the scrcpy window

Please review/test on your platform :) Feedbacks welcome.

I'll probably merge in dev soon.

Thank you

Add Ctrl+Left and Ctrl+Right to rotate the scrcpy window.

Contrary to --lock-video-orientation, the rotation has no impact on
recording, and can be changed dynamically (and immediately).

Fixes #218 <#218>
@dre-z17
Copy link

dre-z17 commented Apr 7, 2020

My phone must be a piece.

Screen rotation works with all apps other than my built in camera app. The SCRCPY window within my PC refuses to rotate out of vertical portrait layout to a horizontal landscape layout.

I've attached screenshot. The image shows multiple 'request to rotate' msgs but nothing happens.

Hopefully a screenshot doesn't violate tos :(
no landscape

Maybe I failed to uninstall the old build correctly(?). Will keep trying when I'm free tomorrow. I have appointments remainder of the day and an evening event too.

Thx for a killer app nonetheless.

@rom1v
Copy link
Collaborator Author

rom1v commented Apr 8, 2020

You requested to rotate to landscape, but the app refuses. This is expected for many camera apps.

The new feature in this PR consists in rotating the scrcpy window with Ctrl+LEFT and Ctrl+RIGHT.

@rom1v
Copy link
Collaborator Author

rom1v commented Apr 8, 2020

Feature merged in dev.

I also added --rotation value to set the initial rotation.

@rom1v rom1v closed this Apr 8, 2020
@rom1v rom1v changed the title Add shortcuts to rotate client window Add shortcuts to rotate display Apr 14, 2020
@perrette
Copy link

Excellent app and great feature !
For whoever ends here, it seems to have been changed to ALT + LEFT and ALT + RIGHT (scrcpy 2.3.1, Ubuntu 22.04).

@rom1v
Copy link
Collaborator Author

rom1v commented Jan 22, 2024

@perrette Yes, the default shortcuts modifier was changed a long time ago (in v1.15 by #1598).

https://github.com/Genymobile/scrcpy/blob/master/doc/shortcuts.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants